From owner-freebsd-stable@FreeBSD.ORG Mon Feb 4 16:09:21 2008 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D3EBE16A41B; Mon, 4 Feb 2008 16:09:21 +0000 (UTC) (envelope-from avg@icyb.net.ua) Received: from falcon.cybervisiontech.com (falcon.cybervisiontech.com [217.20.163.9]) by mx1.freebsd.org (Postfix) with ESMTP id 4EDAD13C47E; Mon, 4 Feb 2008 16:09:21 +0000 (UTC) (envelope-from avg@icyb.net.ua) Received: from localhost (localhost [127.0.0.1]) by falcon.cybervisiontech.com (Postfix) with ESMTP id 3676843F21C; Mon, 4 Feb 2008 18:09:20 +0200 (EET) X-Virus-Scanned: Debian amavisd-new at falcon.cybervisiontech.com Received: from falcon.cybervisiontech.com ([127.0.0.1]) by localhost (falcon.cybervisiontech.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GMoGIBdWLF3D; Mon, 4 Feb 2008 18:09:20 +0200 (EET) Received: from [10.2.1.87] (gateway.cybervisiontech.com.ua [88.81.251.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by falcon.cybervisiontech.com (Postfix) with ESMTP id CAFC643F21B; Mon, 4 Feb 2008 18:09:19 +0200 (EET) Message-ID: <47A738AE.5070900@icyb.net.ua> Date: Mon, 04 Feb 2008 18:09:18 +0200 From: Andriy Gapon User-Agent: Thunderbird 2.0.0.9 (X11/20080123) MIME-Version: 1.0 References: <4799D78F.6000405@icyb.net.ua> <47A097FA.3090303@icyb.net.ua> <20080130164508.GC6257@suse.cz> <47A2E7E5.1040307@icyb.net.ua> <20080201093806.GA4632@suse.cz> In-Reply-To: <20080201093806.GA4632@suse.cz> Content-Type: multipart/mixed; boundary="------------060302010604060102000307" Cc: freebsd-stable@freebsd.org, freebsd-hardware@freebsd.org Subject: Re: ps/2 mouse patch X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Feb 2008 16:09:21 -0000 This is a multi-part message in MIME format. --------------060302010604060102000307 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit on 01/02/2008 11:38 Vojtech Pavlik said the following: > On Fri, Feb 01, 2008 at 11:35:33AM +0200, Andriy Gapon wrote: >> I compared FreeBSD and Linux sources more thoroughly and found the >> following: >> http://lxr.linux.no/linux+v2.6.24/drivers/input/mouse/psmouse-base.c#L464 >> static int im_explorer_detect(struct psmouse *psmouse, int set_properties) >> { >> struct ps2dev *ps2dev = &psmouse->ps2dev; >> unsigned char param[2]; >> >> intellimouse_detect(psmouse, 0); >> >> I.e., first thing the explorer probe does is massaging a mouse with >> IntelliMouse magic commands. >> >> I did the same in FreeBSD psm.c, i.e., added a call to >> enable_msintelli() at the very start of enable_msexplorer(). And voilą - >> everything is perfect, correct ID is returned, probing succeeds, the >> mouse works great. >> >> I think that this change is quite safe to make in FreeBSD, because with >> Linux user-base we can be 99% percent sure that this change won't break >> anything. > > It is even correct: A mouse isn't required to be able to jump straight > into the Explorer mode, it is supposed to always go through the > IntelliMouse mode. Any takers to test this change with your current PS/2 mouse (either working or non-working) ? Any takers to commit this change ? :-) Will this issue get more traction if I file a PR? -- Andriy Gapon --------------060302010604060102000307 Content-Type: text/x-patch; name="psm.c.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="psm.c.patch" --- psm.c.orig 2008-02-04 18:07:34.000000000 +0200 +++ psm.c 2008-02-04 18:08:14.000000000 +0200 @@ -3109,6 +3109,8 @@ enable_msexplorer(struct psm_softc *sc) int id; int i; + enable_msintelli(sc); + /* the special sequence to enable the extra buttons and the roller. */ for (i = 0; i < sizeof(rate1)/sizeof(rate1[0]); ++i) { if (set_mouse_sampling_rate(kbdc, rate1[i]) != rate1[i]) --------------060302010604060102000307--