From owner-svn-src-all@FreeBSD.ORG Mon Apr 29 00:06:25 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 493103DB; Mon, 29 Apr 2013 00:06:25 +0000 (UTC) (envelope-from hiren.panchasara@gmail.com) Received: from mail-ee0-f41.google.com (mail-ee0-f41.google.com [74.125.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id A5DB71C8E; Mon, 29 Apr 2013 00:06:23 +0000 (UTC) Received: by mail-ee0-f41.google.com with SMTP id c50so2120396eek.28 for ; Sun, 28 Apr 2013 17:06:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=R4LPU2EGJLxVVJMrMZqDsHwM1nuLt0omHiOPp2aaI5M=; b=XR8hxq28ibRObv4asIO7DFSjU9xqT07O1yWzoRYccF0k3C/rO1aQpsfdMIKePH4pK8 7/mv0iVdjepy5GkC8okmyLY2C0tP2EtS0b5K8qPUdRVLMaXFUIVCat9PE6Zm0/Acbx4z GqjCRyb9us/htRvEBHYGJliYcFdwXjgWw3Ei1Qd68A65LSEwwgyEtCLBR2DtXlmCD3hh LXtdz+pCzBoPDEWFmLbSPNYJ9xP6n5wtUYf6hJMRmbM4Q79UN700S4KK6SScHetwDCkl zvwULUfeMn78bose2+Hg0ll/i5HnQb704zg1dZuJuFNP/6AVRdPxHuS0mRiom7xeehBg 6O9w== MIME-Version: 1.0 X-Received: by 10.14.219.8 with SMTP id l8mr16887076eep.40.1367193976535; Sun, 28 Apr 2013 17:06:16 -0700 (PDT) Sender: hiren.panchasara@gmail.com Received: by 10.14.204.200 with HTTP; Sun, 28 Apr 2013 17:06:16 -0700 (PDT) In-Reply-To: References: <201304231302.r3ND2w5V024981@svn.freebsd.org> Date: Sun, 28 Apr 2013 17:06:16 -0700 X-Google-Sender-Auth: kTjpxDkdAATQZH29CKVT3z5SSqQ Message-ID: Subject: Re: svn commit: r249800 - head/sys/dev/bwn From: hiren panchasara To: John Baldwin Content-Type: text/plain; charset=UTF-8 Cc: svn-src-head , Adrian Chadd , src-committers , Eitan Adler , svn-src-all X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Apr 2013 00:06:25 -0000 On Tue, Apr 23, 2013 at 9:46 AM, hiren panchasara wrote: > On Tue, Apr 23, 2013 at 9:34 AM, Eitan Adler wrote: >> On 23 April 2013 12:19, Adrian Chadd wrote: >>> ... you know, even though it doesn't have an active maintainer, do you >>> have test hardware, and why didn't you just bounce a patch to >>> -wireless for review? > > My bad. I proposed this change initially. >>> >>> We don't bite you know! >> >> that you need to emphasize this does not comfort me. ;) >> >> reverted in 249812. > > Will look at john's suggestions and fix it correctly. John, Does this look okay? % svn diff Index: if_bwn.c =================================================================== --- if_bwn.c (revision 250036) +++ if_bwn.c (working copy) @@ -9240,9 +9240,9 @@ BUS_DMASYNC_PREWRITE); /* - * Setup RX buf descriptor + * Restore RX buf descriptor */ - dr->setdesc(dr, desc, paddr, meta->mt_m->m_len - + dr->setdesc(dr, desc, meta->mt_paddr, meta->mt_m->m_len - sizeof(*hdr), 0, 0, 0); return (error); } Thanks, Hiren > > Hiren >> >> -- >> Eitan Adler >> Source, Ports, Doc committer >> Bugmeister, Ports Security teams