From owner-svn-src-all@FreeBSD.ORG Wed May 7 07:57:51 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6969730A; Wed, 7 May 2014 07:57:51 +0000 (UTC) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 570312EF; Wed, 7 May 2014 07:57:51 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.8/8.14.8) with ESMTP id s477vpVp030293; Wed, 7 May 2014 07:57:51 GMT (envelope-from adrian@svn.freebsd.org) Received: (from adrian@localhost) by svn.freebsd.org (8.14.8/8.14.8/Submit) id s477vpBC030292; Wed, 7 May 2014 07:57:51 GMT (envelope-from adrian@svn.freebsd.org) Message-Id: <201405070757.s477vpBC030292@svn.freebsd.org> From: Adrian Chadd Date: Wed, 7 May 2014 07:57:51 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r265527 - head/sys/dev/ath X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 May 2014 07:57:51 -0000 Author: adrian Date: Wed May 7 07:57:50 2014 New Revision: 265527 URL: http://svnweb.freebsd.org/changeset/base/265527 Log: There's no need to be this paranoid - ni is deferenced before this point. Coverity ID: CID 1211937 Modified: head/sys/dev/ath/if_ath_rx.c Modified: head/sys/dev/ath/if_ath_rx.c ============================================================================== --- head/sys/dev/ath/if_ath_rx.c Wed May 7 07:56:36 2014 (r265526) +++ head/sys/dev/ath/if_ath_rx.c Wed May 7 07:57:50 2014 (r265527) @@ -344,7 +344,7 @@ ath_recv_mgmt(struct ieee80211_node *ni, #define TU_TO_TSF(_tu) (((u_int64_t)(_tu)) << 10) tsf_intval = 1; - if (ni != NULL && ni->ni_intval > 0) { + if (ni->ni_intval > 0) { tsf_intval = TU_TO_TSF(ni->ni_intval); } #undef TU_TO_TSF