From owner-freebsd-current@FreeBSD.ORG Wed Mar 3 09:09:56 2010 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 10199106566C; Wed, 3 Mar 2010 09:09:56 +0000 (UTC) (envelope-from ray@dlink.ua) Received: from dlink.ua (smtp.dlink.ua [193.138.187.146]) by mx1.freebsd.org (Postfix) with ESMTP id 8E2678FC08; Wed, 3 Mar 2010 09:09:54 +0000 (UTC) Received: from gw ([192.168.10.10] helo=terran) by dlink.ua with esmtpsa (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1NmkY8-0000IU-2Y; Wed, 03 Mar 2010 11:07:24 +0200 Date: Wed, 3 Mar 2010 11:10:14 +0200 From: Alexandr Rybalko To: Weongyo Jeong Message-Id: <20100303111014.6564ea1e.ray@dlink.ua> In-Reply-To: <20100303082833.GB22865@weongyo> References: <20091223035331.GA1293@weongyo> <4b31cb29.9413f30a.5f4a.ffff8382@mx.google.com> <20100226005115.GP14937@weongyo> <20100227011535.ed3f2486.ray@ddteam.net> <20100228095259.GB3536@weongyo> <20100301103240.3a4aac8a.ray@dlink.ua> <20100303082833.GB22865@weongyo> Organization: D-Link X-Mailer: Sylpheed 2.7.1 (GTK+ 2.16.6; i386-portbld-freebsd8.0) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Wed, 03 Mar 2010 12:22:50 +0000 Cc: Alex RAY , current@freebsd.org, Weongyo Jeong Subject: Re: Call for Test and Review: bwn(4) - another Broadcom Wireless driver X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Mar 2010 09:09:56 -0000 On Wed, 3 Mar 2010 00:28:33 -0800 Weongyo Jeong wrote: >> On Mon, Mar 01, 2010 at 10:32:40AM +0200, Alexandr Rybalko wrote: >> > On Sun, 28 Feb 2010 01:52:59 -0800 >> > Weongyo Jeong wrote: >> > >> > Can You test your driver without siba_switchcore, I see the device >> > have mapping for all cores on SSB? >> >> I see what you mean. siba_core.c which depends on PCI code would be >> compiled when it builds on SENTRY5. So it looks currently it needs a >> patch to compile siba bus code without PCI code. I'll try to make a >> patch. I now trying to make bus independent interface, not done yet. When finish, I send to You for review and maybe test. >> >> > > ssb0: mem 0xf4000000-0xf4003fff >> > Think thre is 4 cores. >> > When SSB on nexus, we don`t need core switching, maybe on PCI too. >> >> I think this is a difference between siba(4) and siba_bwn currently and >> it's one of TODOs we should solve to merge two codes. >> >> AFAIK approach to access each cores isn't same; it looks siba(4) creates >> devices for each cores so it'd not need to switch cores. But siba_bwn >> doesn't do it like siba(4) so it needs to switch cores because all are >> handled on one device. Look into this line: ssb0: mem 0xf4000000-0xf4003fff There we see, device have 0x4000 memory window. Each core required 0x1000. Your code to call required core move PCI window to appropriate 0x1000 block (if core - second, move to 0xf4001000). Maybe we can map full window, and then access to required core without core switching. >> >> regards, >> Weongyo Jeong >> -- Рыбалко Александр Консультант D-Link Украина