From owner-freebsd-current@FreeBSD.ORG  Sun Mar 20 12:43:21 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id CFF9D16A4CE; Sun, 20 Mar 2005 12:43:20 +0000 (GMT)
Received: from darkness.comp.waw.pl (darkness.comp.waw.pl [195.117.238.136])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 64D6D43D31; Sun, 20 Mar 2005 12:43:20 +0000 (GMT)
	(envelope-from pjd@darkness.comp.waw.pl)
Received: by darkness.comp.waw.pl (Postfix, from userid 1009)
	id 63246ACAE6; Sun, 20 Mar 2005 13:43:18 +0100 (CET)
Date: Sun, 20 Mar 2005 13:43:18 +0100
From: Pawel Jakub Dawidek <pjd@FreeBSD.org>
To: Giorgos Keramidas <keramida@freebsd.org>
Message-ID: <20050320124318.GY591@darkness.comp.waw.pl>
References: <20050106191201.GA30826@gothmog.gr>
	<20050106195719.GB24896@odin.ac.hmc.edu>
	<20050106225857.GB784@darkness.comp.waw.pl>
	<20050106191201.GA30826@gothmog.gr> <20050106195719.GB24896@odin.ac.hmc.edu>
	<20050106195950.GA34916@gothmog.gr> <20050106200718.GD24896@odin.ac.hmc.edu>
	<20050320081104.GA64458@gothmog.gr>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="ds9maZbwT7uk2FVi"
Content-Disposition: inline
In-Reply-To: <20050320081104.GA64458@gothmog.gr>
User-Agent: Mutt/1.4.2i
X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc
X-OS: FreeBSD 5.2.1-RC2 i386
cc: freebsd-current@freebsd.org
Subject: Re: human-readable swap partition sizes with pstat -sh
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 20 Mar 2005 12:43:21 -0000


--ds9maZbwT7uk2FVi
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Mar 20, 2005 at 10:11:04AM +0200, Giorgos Keramidas wrote:
+> On 2005-01-06 23:58, Pawel Jakub Dawidek <pjd@freebsd.org> wrote:
+> > I like intmax_t also much better than int64_t, but I took it from
+> > NetBSD and they got int64_t there. Anyway, I think we don't have to be
+> > 100% compatible here and I'll look what can be done.
+>=20
+> Bearing this in mind, is it ok then if I commit the pstat changes shown
+> below, which use intmax_t or is it better to change all the intmax_t
+> instances in pstat.c to int64_t?

Use int64_t. We decided not to use intmax_t in humanize_number(3), because
then we need to include inttypes.h from libutil.h and this is just too
nasty.

The patch looks ok.

--=20
Pawel Jakub Dawidek                       http://www.wheel.pl
pjd@FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!

--ds9maZbwT7uk2FVi
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)

iD8DBQFCPW/mForvXbEpPzQRArTMAJ92EupVXBtL2FxXrleLwYkwggN9oACfYf9m
qAyWrIdvAjGJ5BNcXuz0ISQ=
=gL9c
-----END PGP SIGNATURE-----

--ds9maZbwT7uk2FVi--