From owner-svn-ports-all@FreeBSD.ORG  Thu Dec 26 18:07:05 2013
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id EA3C34C0;
 Thu, 26 Dec 2013 18:07:05 +0000 (UTC)
Received: from mailrelay004.isp.belgacom.be (mailrelay004.isp.belgacom.be
 [195.238.6.170])
 by mx1.freebsd.org (Postfix) with ESMTP id D37D81568;
 Thu, 26 Dec 2013 18:07:04 +0000 (UTC)
X-Belgacom-Dynamic: yes
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: AmcGAH5vvFJbsLLQ/2dsb2JhbABYgwu6WoEVF3SCJQEBAQRWIxALGAklDyoeGYgIAccfF48dBxaEIASYFpIVgy47
Received: from 208.178-176-91.adsl-dyn.isp.belgacom.be (HELO
 kalimero.tijl.coosemans.org) ([91.176.178.208])
 by relay.skynet.be with ESMTP; 26 Dec 2013 19:05:53 +0100
Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org
 [127.0.0.1])
 by kalimero.tijl.coosemans.org (8.14.7/8.14.7) with ESMTP id rBQI5pD0085269;
 Thu, 26 Dec 2013 19:05:52 +0100 (CET)
 (envelope-from tijl@coosemans.org)
Date: Thu, 26 Dec 2013 19:05:50 +0100
From: Tijl Coosemans <tijl@coosemans.org>
To: marino@freebsd.org
Subject: Re: svn commit: r337389 - head/sysutils/hdup/files
Message-ID: <20131226190550.3062c31b@kalimero.tijl.coosemans.org>
In-Reply-To: <52BC3075.1040003@marino.st>
References: <201312242135.rBOLZsAX084602@svn.freebsd.org>
 <E682A0572B6DA7A6CA834613@ogg.in.absolight.net>
 <52BC3075.1040003@marino.st>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: Mathieu Arnold <mat@FreeBSD.org>, svn-ports-head@freebsd.org,
 svn-ports-all@freebsd.org, ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Dec 2013 18:07:06 -0000

On Thu, 26 Dec 2013 14:34:45 +0100 John Marino wrote:
> On 12/26/2013 14:09, Mathieu Arnold wrote:
>> Hi,
>>=20
>> +--On 24 d=E9cembre 2013 21:35:54 +0000 John Marino <marino@FreeBSD.org>
>> wrote:
>> | Log:
>> |   sysutils/hdup: Unbreak on FreeBSD 10+
>> |  =20
>> |   The breakage was caused by processing makefiles with bmake instead of
>> | the   specified gmake.
>> |  =20
>> |   PR:		ports/184617
>> |   Approved by:	maintainer timeout
>>=20
>> Just splitting hairs a bit, here, but, your commit was not approved by
>> anything, to be exact, it should have read more like :
>>=20
>> ------
>> sysutils/hdup: Unbreak on FreeBSD 10+
>>=20
>> The breakage was caused by processing makefiles with bmake instead of the
>> specified gmake.
>>=20
>> maintainer timeout (here an optional number of days/months, if you like)
>>=20
>> PR:		ports/184617
>=20
> Does it matter?  This is how I did all my commit messages during the
> probation period.  Anyway, I interpret "timeout" as implicit permission
> so I always thought it did apply.

I also use "Approved by: maintainer timeout (N days/weeks/months)".
It makes it clear that approval is normally required.  Not sure where
I picked up this practice though.