From owner-cvs-src@FreeBSD.ORG Tue Apr 15 00:51:46 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EAEBB1065670 for ; Tue, 15 Apr 2008 00:51:45 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from wa-out-1112.google.com (wa-out-1112.google.com [209.85.146.177]) by mx1.freebsd.org (Postfix) with ESMTP id AB2FE8FC14 for ; Tue, 15 Apr 2008 00:51:45 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: by wa-out-1112.google.com with SMTP id k17so2438501waf.3 for ; Mon, 14 Apr 2008 17:51:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:received:date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; bh=Spuy5qXehyEzGwF9/m1WzK81S7vyrM0fmGApg/cqbC4=; b=HZ5kbKSoipm0YeaV84oGQMykNBa4WS/N6386LKPZmu5RlDLBsB/8jFSgHN3bUQsvzpaDgSEN36P2BPywt4++8YBkG2/FUHgHlzQdhxRWjY1sSZe5iqsWaFc+w9mehjfUlEUx5hLN0ll/AR1OTh9fW6HqKB+e5orRiIZyeU1Gw4c= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=oxzsLsNjfb4KCaUK+ut30B2w3bNY7p9yGJzD815vcmkYFZ0MtdNElPj+YFLY8scA9R96TIvvXgWSWWOHsSzmrx6sjFiJPY7anM2DRc786driKp12DwM+0GD4Gi8iqd+1iLMJbzGreASoQvDHzodePts/JK4hNiaCDkiLbd2zMus= Received: by 10.115.32.1 with SMTP id k1mr7728588waj.107.1208220705021; Mon, 14 Apr 2008 17:51:45 -0700 (PDT) Received: from michelle.cdnetworks.co.kr ( [211.53.35.84]) by mx.google.com with ESMTPS id m27sm15690655wag.50.2008.04.14.17.51.41 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 14 Apr 2008 17:51:43 -0700 (PDT) Received: from michelle.cdnetworks.co.kr (localhost.cdnetworks.co.kr [127.0.0.1]) by michelle.cdnetworks.co.kr (8.13.5/8.13.5) with ESMTP id m3F0pcfx020341 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 15 Apr 2008 09:51:38 +0900 (KST) (envelope-from pyunyh@gmail.com) Received: (from yongari@localhost) by michelle.cdnetworks.co.kr (8.13.5/8.13.5/Submit) id m3F0pbLf020340; Tue, 15 Apr 2008 09:51:37 +0900 (KST) (envelope-from pyunyh@gmail.com) Date: Tue, 15 Apr 2008 09:51:36 +0900 From: Pyun YongHyeon To: Remko Lodder Message-ID: <20080415005136.GA19926@cdnetworks.co.kr> References: <968902.70296.qm@web33708.mail.mud.yahoo.com> <20080414010849.GF15616@cdnetworks.co.kr> <480395C8.5010003@elvandar.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <480395C8.5010003@elvandar.org> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Abdullah Ibn Hamad Al-Marri Subject: Re: cvs commit: src/sys/dev/re if_re.c src/sys/pci if_rlreg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Apr 2008 00:51:46 -0000 On Mon, Apr 14, 2008 at 07:35:04PM +0200, Remko Lodder wrote: > Pyun YongHyeon wrote: > >On Wed, Apr 09, 2008 at 12:34:01PM -0700, Abdullah Ibn Hamad Al-Marri > >wrote: > > > ----- Original Message ---- > > > > From: Pyun YongHyeon > > > > To: src-committers@FreeBSD.org; cvs-src@FreeBSD.org; > > cvs-all@FreeBSD.org > > > > Sent: Monday, March 31, 2008 7:03:14 AM > > > > Subject: cvs commit: src/sys/dev/re if_re.c src/sys/pci if_rlreg.h > > > > > > > > yongari 2008-03-31 04:03:14 UTC > > > > > > > > FreeBSD src repository > > > > > > > > Modified files: > > > > sys/dev/re if_re.c > > > > sys/pci if_rlreg.h > > > > Log: > > > > Padding more bytes than necessary one broke another variants of > > > > PCIe RealTek chips. Only pad IP packets if the payload is less than > > > > 28 bytes. > > > > > > > > Obtained from: NetBSD > > > > PR: kern/122221 > > > > > > > > Revision Changes Path > > > > 1.113 +1 -1 src/sys/dev/re/if_re.c > > > > 1.74 +6 -0 src/sys/pci/if_rlreg.h > > > > > > Hello Pyun, > > > > > > I hope you are doing well. > > > > > > This is a friendly reminder... > > > > > > It has been more than a week since you said you'll MFC the re changes > > to RELENG_7 > > > > > > I still suffer of the current patch and the re poor performance. > > > > > > Thank you in advance, > > > > > > >There was one regression report from remko so we are testing a patch. > >It seems that the regression is hard to reproduce at will it may > >take more time. I'll MFC all changes to RELENG_7 as soon as he say Ok. > > > >Thanks for remiding this! > > Hi all, > > I think Pyun can MFC the changes where needed / possible because I > couldn't trigger it so far. Last time it took me several days to get > the machine down, so one never knows when I can reproduce it again. I > am getting a new (Second) machine to test this with somewhere this week > so that I can 'dedicatedly' test the patch and try to reproduce it even > quicker :-) > > That said; I think the changes made by pyun are a substantial > improvement nevertheless and should (Where possible) not be withheld > from people :) > > Pyun please process this when possible :-) > First, I'll commit the patch you tested and wait a couple of days before MFCing re(4) to RELENG_7. Thanks for all your hardwork and continuous support! -- Regards, Pyun YongHyeon