From owner-cvs-all@FreeBSD.ORG Fri Jan 23 17:56:00 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F37DE16A4CE; Fri, 23 Jan 2004 17:55:59 -0800 (PST) Received: from creme-brulee.marcuscom.com (rrcs-midsouth-24-172-16-118.biz.rr.com [24.172.16.118]) by mx1.FreeBSD.org (Postfix) with ESMTP id D8CDB43D49; Fri, 23 Jan 2004 17:55:54 -0800 (PST) (envelope-from marcus@marcuscom.com) Received: from [192.168.1.4] (shumai.marcuscom.com [192.168.1.4]) i0O1rtsm005497; Fri, 23 Jan 2004 20:53:55 -0500 (EST) (envelope-from marcus@marcuscom.com) From: Joe Marcus Clarke To: Daniel Eischen In-Reply-To: References: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-i02DaufzXJ0A8dS4SC1N" Organization: MarcusCom, Inc. Message-Id: <1074909348.1546.1.camel@shumai.marcuscom.com> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.5 Date: Fri, 23 Jan 2004 20:55:48 -0500 X-Spam-Status: No, hits=-4.9 required=5.0 tests=BAYES_00 autolearn=ham version=2.61 X-Spam-Checker-Version: SpamAssassin 2.61 (1.212.2.1-2003-12-09-exp) on creme-brulee.marcuscom.com cc: cvs-ports@FreeBSD.org cc: Adam Weinberger cc: cvs-all@FreeBSD.org cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/Mk bsd.port.mk X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Jan 2004 01:56:00 -0000 --=-i02DaufzXJ0A8dS4SC1N Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Fri, 2004-01-23 at 19:40, Daniel Eischen wrote: > On 23 Jan 2004, Adam Weinberger wrote: >=20 > > >> (01.23.2004 @ 1930 PST): Daniel Eischen said, in 0.7K: << > > > On 23 Jan 2004, Adam Weinberger wrote: > > >=20 > > > > >> (01.23.2004 @ 1731 PST): Daniel Eischen said, in 0.3K: << > > > > > deischen 2004/01/23 14:31:36 PST > > > > >=20 > > > > > FreeBSD ports repository > > > > >=20 > > > > > Modified files: > > > > > Mk bsd.port.mk=20 > > > > > Log: > > > > > Make PTHREAD_LIBS and PTHREAD_CFLAGS conditional. Also remove > > > > > -D_THREAD_SAFE from PTHREAD_CFLAGS when it isn't needed. > > > > > =20 > > > > > Revision Changes Path > > > > > 1.482 +3 -3 ports/Mk/bsd.port.mk > > > > >> end of "cvs commit: ports/Mk bsd.port.mk" from Daniel Eischen << > > > >=20 > > > > Was this change approved by portmgr? > > >=20 > > > Not explicity, but portmgr is well aware of what's going on > > > (hint: s/-lc_r/-lpthread). > > >> end of "Re: cvs commit: ports/Mk bsd.port.mk" from Daniel Eischen << > >=20 > > I was going to make a comment about not recalling any messages to > > portmgr@ about this, but I think it's a case of seeing something so muc= h > > that you cease to see it anymore. ::P >=20 > Well, I admit I'm at fault here. I didn't notice the big friggin' > notice at the beginning of the file: >=20 > # DO NOT COMMIT CHANGES TO THIS FILE BY YOURSELF, EVEN IF YOU DID NOT G= ET > # A RESPONSE FROM THE MAINTAINER(S) WITHIN A REASONABLE TIMEFRAME! ALL > # UNAUTHORISED CHANGES WILL BE UNCONDITIONALLY REVERTED! >=20 > portmgr has been CC'd in all our email, but I never explicitly asked > for permission to do this specific change. >=20 > If you want, I can back it out. It's best to back this out. There is an interesting discussion on portmgr@ right now, and I think it's best we wait on the pthread thing for a little bit. Besides, I want to do another experimental patch build very soon, so I'll be sure to add this. Joe --=20 PGP Key : http://www.marcuscom.com/pgp.asc --=-i02DaufzXJ0A8dS4SC1N Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQBAEdCkb2iPiv4Uz4cRAiacAJ9NnZ1WiVaxMIr9z7rcsusRWmF2NwCfU28V h4nD8BP4pbZP9UylwipnF2o= =vXmL -----END PGP SIGNATURE----- --=-i02DaufzXJ0A8dS4SC1N--