From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Mar 23 13:29:22 2006 Return-Path: X-Original-To: freebsd-ports-bugs@FreeBSD.org Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E898A16A401; Thu, 23 Mar 2006 13:29:22 +0000 (UTC) (envelope-from frank@dynamical-systems.org) Received: from mout0.freenet.de (mout0.freenet.de [194.97.50.131]) by mx1.FreeBSD.org (Postfix) with ESMTP id DEFDD43D5E; Thu, 23 Mar 2006 13:29:19 +0000 (GMT) (envelope-from frank@dynamical-systems.org) Received: from [194.97.55.242] (helo=mx9.freenet.de) by mout0.freenet.de with esmtpa (Exim 4.61) (envelope-from ) id 1FMPsM-0006CV-Td; Thu, 23 Mar 2006 14:29:18 +0100 Received: from p508e9486.dip0.t-ipconnect.de ([80.142.148.134] helo=jumper4.senax.net) by mx9.freenet.de with esmtpsa (ID jr-relay@freenet.de) (TLSv1:AES256-SHA:256) (Exim 4.61 #1) id 1FMPsM-00087d-JS; Thu, 23 Mar 2006 14:29:18 +0100 Received: from pollux.senax.net (pollux.senax.net [192.168.1.112]) by jumper4.senax.net (8.13.5/8.13.5) with ESMTP id k2NDTCKa002204; Thu, 23 Mar 2006 14:29:13 +0100 (CET) (envelope-from frank@dynamical-systems.org) Date: Thu, 23 Mar 2006 14:29:12 +0100 (CET) From: "Frank W. Josellis" To: Thierry Thomas In-Reply-To: <200603222154.k2MLsUZJ038943@freefall.freebsd.org> Message-ID: <20060323133612.J6641@pollux.senax.net> References: <200603222154.k2MLsUZJ038943@freefall.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/93972: Update port: astro/xmoontool to 3.0.3 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Mar 2006 13:29:23 -0000 On Wed, 22 Mar 2006, Thierry Thomas wrote: > This port does not respect CFLAGS, CC nor PREFIX; what about the > following patch? (Since I'm there, reorganize Makefile) You are right, but please note that patching PREFIX into the tarball's Makefile has no effect on the port. It's only the install target that involves PREFIX. This isn't used, as the port's installation is solely carried out by do-install in the port's Makefile. Well, I considered the tarball's CC and CFLAGS settings as acceptable for the port and couldn't imagine a situation where it is essential to have them overwritten. But I suppose you are more acquainted with the formal requirements on FreeBSD ports, so I better leave it to you. If you feel it's an advantage which justifies the patch, I won't protest. I wasn't yet aware that USE_REINPLACE meanwhile became obsolete, but I'll know in future. Thanks! Frank Josellis