From owner-svn-ports-all@FreeBSD.ORG Sat Apr 20 13:48:52 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id B5C5E8FA; Sat, 20 Apr 2013 13:48:52 +0000 (UTC) (envelope-from ganael.laplanche@martymac.org) Received: from lmtp.galacsys.net (webmail.galacsys.net [IPv6:2001:1b78:0:1:d918:51d7:0:1]) by mx1.freebsd.org (Postfix) with ESMTP id 7F95B1E1E; Sat, 20 Apr 2013 13:48:52 +0000 (UTC) Received: from martymac.org (webmail.galacsys.net [217.24.81.215]) by lmtp.galacsys.net (Postfix) with ESMTP id 23E8B1FA5CEA; Sat, 20 Apr 2013 15:48:50 +0200 (CEST) From: "Ganael LAPLANCHE" To: Alexey Dokuchaev ,Eitan Adler Subject: Re: svn commit: r316102 - in head/emulators/dolphin-emu-devel: . files X-Openwebmail-Date: Sat, 20 Apr 2013 16:48:50 +0200 Message-Id: <20130420133158.M15119@martymac.org> In-Reply-To: <20130420051737.GA23612@FreeBSD.org> References: <201304191335.r3JDZF4B031649@svn.freebsd.org> <20130419134935.GA29457@FreeBSD.org> <20130419150333.M65185@FreeBSD.org> <20130420051737.GA23612@FreeBSD.org> X-Mailer: Open WebMail 2.01 20030425 X-OriginatingIP: 88.163.147.236 (ganael.laplanche@martymac.org) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Date: Sat, 20 Apr 2013 13:48:52 +0000 (UTC) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Ganael LAPLANCHE , ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Apr 2013 13:48:52 -0000 On Sat, 20 Apr 2013 05:17:37 +0000, Alexey Dokuchaev wrote Hi Alexey, Eitan, > > No. > > > > ONLY_FOR_* means that the port is *never intended* to work on any > > other platform. BROKEN ports are, in theory, periodically tested. > > Exactly. I only mentioned ONLY_FOR_ARCHS to illustrate that > "i386-specific option" is overly vague even to tell BROKEN > from ONLY_FOR_ARCHS, which are very different beasts, and > should not be confused. Thanks for the reminder ! Of course, ONLY_FOR_ARCHS won't fit here. Then, I see three possibilities : 1) Fix the BROKEN message with something more incentive, like just : .if ${ARCH} == "powerpc" BROKEN= Not tested on powerpc .endif but I don't find this solution very clean as, after all, I have not tested other tier-2 architectures, so why just put a message for powerpc ? 2) I could rewrite it this way : .if ${ARCH} != "i386" && ${ARCH} != "amd64" BROKEN= Only tested on i386 and amd64 .endif a kind of ONLY_FOR_ARCHS that will allow package building to be tried anyway from time to time. 3) As I don't know exactly why this BROKEN message has been introduced and whether the port now builds or not on powerpc and other tier-2 archs (I don't have hardware to test it), just remove the BROKEN message and let the port live its life. I would go for 2) as it seems the cleanest way to solve that problem. Does that seem good to you ? Best regards, -- Ganael LAPLANCHE http://www.martymac.org | http://contribs.martymac.org FreeBSD: martymac , http://www.FreeBSD.org