From owner-freebsd-current@FreeBSD.ORG Tue Mar 15 05:42:02 2005 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 026F916A4CE for ; Tue, 15 Mar 2005 05:42:02 +0000 (GMT) Received: from wproxy.gmail.com (wproxy.gmail.com [64.233.184.204]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1A5BB43D2F for ; Tue, 15 Mar 2005 05:42:00 +0000 (GMT) (envelope-from jiashiun@gmail.com) Received: by wproxy.gmail.com with SMTP id 58so3707wri for ; Mon, 14 Mar 2005 21:41:57 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:in-reply-to:mime-version:content-type:references; b=N5yhJF/OaqVugFJWrQTciXO6E20pM7g4r3ttsTMTtXwTicVnDn/YZrPUKd6GCd5I0y406ObsFyihMIx6jrZrO4oj0GseRyo+aZWGTf79DlTTK4IxMp/MPqQuYrQvPZnRgEbTxiRdkQVol0GbMYu3fHwe212R1zN2poItDXI7hHs= Received: by 10.38.90.36 with SMTP id n36mr1827212rnb; Mon, 14 Mar 2005 08:07:09 -0800 (PST) Received: by 10.38.12.68 with HTTP; Mon, 14 Mar 2005 08:07:09 -0800 (PST) Message-ID: <1d6d20bc05031408071558b6ce@mail.gmail.com> Date: Tue, 15 Mar 2005 00:07:09 +0800 From: Jia-Shiun Li To: freebsd-current@freebsd.org, =?ISO-8859-1?Q?S=F8ren_Schmidt?= In-Reply-To: <1d6d20bc0503100101621bbee3@mail.gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_2487_5866869.1110816429686" References: <1d6d20bc0503100101621bbee3@mail.gmail.com> Subject: Re: VESA non-VGA flag X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Jia-Shiun Li List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Mar 2005 05:42:02 -0000 ------=_Part_2487_5866869.1110816429686 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Thu, 10 Mar 2005 17:01:13 +0800, Jia-Shiun Li wrote= : > Hi, >=20 > These days I was trying to add a splash screen. I used VMWare to test, > but it cannot init VESA correctly, which is odd since VMWare claimed > its display to be VESA compliant. I then traced into > src/sys/i386/isa/vesa.c, found that it was cause by the flag V_NONVGA. > It will stop initializing if this flag is set, at line 655(v1.50). If > I comment it out, VESA will work on VMWare and I can happily use my > splash screen during booting. >=20 > I tried to google some info, but still cannot figure out if the > 'non-VGA' flag really means 'not (IBM)VGA backward-compatible' or 'not > a display device at all'. But since anything implementing VBE must be > a display device to make sense, I suppose it to be the former. The > question is, if the checking of non-VGA flag can be safely removed? I > do not know if there is any devices depending on it to work correctly. > To me it seems ok without the checking. >=20 According to VBE 3.0 page 26, the non-vga flag means 'not VGA compatible', so it should not prevent VESA from initializing. I did not found anyone responsible for this. S=F8ren and Ian could you take a look at this patch? It makes VESA work on VMWare without breaking it on other (real)hardwares. Jia-Shiun. --- sys/i386/isa/vesa.c.orig=09Mon Mar 14 23:55:19 2005 +++ sys/i386/isa/vesa.c=09Mon Mar 14 23:55:42 2005 @@ -652,8 +652,6 @@ =09=09printf("VESA: information block\n"); =09=09dump_buffer(buf, 64); =09} -=09if (vesa_adp_info->v_flags & V_NONVGA) -=09=09return 1; =09if (vesa_adp_info->v_version < 0x0102) { =09=09printf("VESA: VBE version %d.%d is not supported; " =09=09 "version 1.2 or later is required.\n", ------=_Part_2487_5866869.1110816429686 Content-Type: text/plain; name="vesa.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="vesa.patch" --- sys/i386/isa/vesa.c.orig=09Mon Mar 14 23:55:19 2005 +++ sys/i386/isa/vesa.c=09Mon Mar 14 23:55:42 2005 @@ -652,8 +652,6 @@ =09=09printf("VESA: information block\n"); =09=09dump_buffer(buf, 64); =09} -=09if (vesa_adp_info->v_flags & V_NONVGA) -=09=09return 1; =09if (vesa_adp_info->v_version < 0x0102) { =09=09printf("VESA: VBE version %d.%d is not supported; " =09=09 "version 1.2 or later is required.\n", ------=_Part_2487_5866869.1110816429686--