From owner-freebsd-current@FreeBSD.ORG Tue Dec 7 12:42:01 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4F5A716A4CE; Tue, 7 Dec 2004 12:42:01 +0000 (GMT) Received: from relay.bestcom.ru (relay.bestcom.ru [217.72.144.5]) by mx1.FreeBSD.org (Postfix) with ESMTP id 707A743D5A; Tue, 7 Dec 2004 12:42:00 +0000 (GMT) (envelope-from glebius@freebsd.org) Received: from cell.sick.ru (root@cell.sick.ru [217.72.144.68]) by relay.bestcom.ru (8.13.1/8.12.9) with ESMTP id iB7CfuSr084370 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Tue, 7 Dec 2004 15:41:56 +0300 (MSK) (envelope-from glebius@freebsd.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.12.11/8.12.8) with ESMTP id iB7CftEc077531 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 7 Dec 2004 15:41:55 +0300 (MSK) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.sick.ru (8.12.11/8.12.11/Submit) id iB7CftNj077530; Tue, 7 Dec 2004 15:41:55 +0300 (MSK) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@freebsd.org using -f Date: Tue, 7 Dec 2004 15:41:54 +0300 From: Gleb Smirnoff To: current@freebsd.org, stable@freebsd.org Message-ID: <20041207124154.GA76825@cell.sick.ru> References: <20041202151048.GA33485@cell.sick.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20041202151048.GA33485@cell.sick.ru> User-Agent: Mutt/1.5.6i X-Virus-Scanned: clamd / ClamAV version devel-20041013, clamav-milter version 0.75l on 127.0.0.1 X-Virus-Status: Clean Subject: Re: [TEST] netgraph callout interface X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Dec 2004 12:42:01 -0000 The patch at http://people.freebsd.org/~glebius/totest/netgraph_callout has been updated. Now it covers the following nodes: ng_bridge.c ng_l2tp.c ng_lmi.c ng_pppoe.c ng_pptpgre.c One more time I ask for testing. The patch can be applied both to HEAD and RELENG_5. On Thu, Dec 02, 2004 at 06:10:48PM +0300, Gleb Smirnoff wrote: T> Dear collegues, T> T> we are working on making netgraph ISR mpsafe. To do it we need to T> fix all (ab)users of bare timeout(9) in src/sys/netgraph. These T> timeout calls are running in synch with netgraph now because timeout(9) T> is Giant-locked. As soon as we mark ISR mpsafe, they are going to break. T> T> This patch semi-mechanically changes all timeout(9) calls to ng_callout(9), T> which runs scheduled callouts in netgraph context: T> T> http://people.freebsd.org/~glebius/totest/netgraph_callout T> T> It can be applied to HEAD or RELENG_5 (not 5.3-RELEASE). It patches T> the following nodes: T> T> ng_bridge.c T> ng_l2tp.c T> ng_lmi.c T> ng_ppp.c T> ng_pppoe.c T> ng_tty.c T> T> If you are using at least one of them, then I'm asking you to test the T> patch and respond. Thanks in advance! T> T> P.S. Sorry for crossposting. The target users are both RELENG_5 and CURRENT. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE