From owner-freebsd-multimedia Tue Feb 3 10:01:48 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id KAA05754 for freebsd-multimedia-outgoing; Tue, 3 Feb 1998 10:01:48 -0800 (PST) (envelope-from owner-freebsd-multimedia@FreeBSD.ORG) Received: from rah.star-gate.com (rah.star-gate.com [209.133.7.178]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id KAA05748 for ; Tue, 3 Feb 1998 10:01:46 -0800 (PST) (envelope-from hasty@rah.star-gate.com) Received: from rah (localhost.star-gate.com [127.0.0.1]) by rah.star-gate.com (8.8.8/8.8.8) with ESMTP id KAA00466; Tue, 3 Feb 1998 10:01:38 -0800 (PST) (envelope-from hasty@rah.star-gate.com) Message-Id: <199802031801.KAA00466@rah.star-gate.com> X-Mailer: exmh version 2.0gamma 1/27/96 To: Luigi Rizzo cc: multimedia@FreeBSD.ORG Subject: Re: bt848 feedback... In-reply-to: Your message of "Tue, 03 Feb 1998 16:03:18 +0100." <199802031503.QAA06191@labinfo.iet.unipi.it> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 03 Feb 1998 10:01:38 -0800 From: Amancio Hasty Sender: owner-freebsd-multimedia@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org X-To-Unsubscribe: mail to majordomo@FreeBSD.org "unsubscribe freebsd-multimedia" Hi, Will move the code down the code next time I commit the driver . Cheers, Amancio > In the latest release of the Bt848 code, I noticed the BT848_I2CWR > ioctl that I submitted some time ago has been put in video_ioctl(), > but it really belongs in tuner_ioctl() , where other I2C devices are > also accessed. > > It's just a matter of moving the block in the other function (and > moving the variable declarations at the beginning of video_ioctl, > a hundred lines above... what was wrong with declaring variables > within the block they are used, as in the patch I submitted!). > > Oh btw the code works perfectly on 2.2.1 > > cheers > luigi > -----------------------------+-------------------------------------- > Luigi Rizzo | Dip. di Ingegneria dell'Informazione > email: luigi@iet.unipi.it | Universita' di Pisa > tel: +39-50-568533 | via Diotisalvi 2, 56126 PISA (Italy) > fax: +39-50-568522 | http://www.iet.unipi.it/~luigi/ > _____________________________|______________________________________