From owner-p4-projects Fri Apr 5 14:59:43 2002 Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 830B437B405; Fri, 5 Apr 2002 14:59:08 -0800 (PST) Delivered-To: perforce@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 08F1937B425 for ; Fri, 5 Apr 2002 14:59:02 -0800 (PST) Received: (from perforce@localhost) by freefall.freebsd.org (8.11.6/8.11.6) id g35Mx1s13232 for perforce@freebsd.org; Fri, 5 Apr 2002 14:59:01 -0800 (PST) (envelope-from jhb@freebsd.org) Date: Fri, 5 Apr 2002 14:59:01 -0800 (PST) Message-Id: <200204052259.g35Mx1s13232@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: perforce set sender to jhb@freebsd.org using -f From: John Baldwin Subject: PERFORCE change 9146 for review To: Perforce Change Reviews Sender: owner-p4-projects@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG http://people.freebsd.org/~peter/p4db/chv.cgi?CH=9146 Change 9146 by jhb@jhb_laptop on 2002/04/05 14:58:05 Merge from jhb_proc: remove a weird diagnostic leftover from KSE. Also, we don't need Giant for suser() now. Affected files ... ... //depot/projects/smpng/sys/kern/kern_acct.c#12 edit Differences ... ==== //depot/projects/smpng/sys/kern/kern_acct.c#12 (text+ko) ==== @@ -119,14 +119,12 @@ struct nameidata nd; int error, flags; - mtx_lock(&Giant); - if (td != curthread) - panic("acct"); /* XXXKSE DIAGNOSTIC */ /* Make sure that the caller is root. */ error = suser(td); if (error) - goto done2; + return (error); + mtx_lock(&Giant); /* * If accounting is to be started to a file, open that file for * writing and make sure it's a 'normal'. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message