From owner-cvs-src@FreeBSD.ORG  Tue Oct 28 09:31:56 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id CC19416A4CE; Tue, 28 Oct 2003 09:31:56 -0800 (PST)
Received: from ebb.errno.com (ebb.errno.com [66.127.85.87])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id A329C43FF5; Tue, 28 Oct 2003 09:31:55 -0800 (PST)
	(envelope-from sam@errno.com)
Received: from 66.127.85.91 ([66.127.85.91])
	(authenticated bits=0)
	by ebb.errno.com (8.12.9/8.12.9) with ESMTP id h9SHVt0x035936
	(version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO);
	Tue, 28 Oct 2003 09:31:55 -0800 (PST)
	(envelope-from sam@errno.com)
From: Sam Leffler <sam@errno.com>
Organization: Errno Consulting
To: Hajimu UMEMOTO <ume@FreeBSD.org>, src-committers@FreeBSD.org,
	cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
Date: Tue, 28 Oct 2003 10:33:33 -0700
User-Agent: KMail/1.5.3
References: <200310281629.h9SGTQnt010293@repoman.freebsd.org>
In-Reply-To: <200310281629.h9SGTQnt010293@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200310280933.33998.sam@errno.com>
Subject: Re: cvs commit: src/sys/netinet6 frag6.c icmp6.c ip6_input.c
	ip6_var.h         route6.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Oct 2003 17:31:56 -0000

On Tuesday 28 October 2003 08:29 am, Hajimu UMEMOTO wrote:
> ume         2003/10/28 08:29:26 PST
>
>   FreeBSD src repository
>
>   Modified files:
>     sys/netinet6         frag6.c icmp6.c ip6_input.c ip6_var.h
>                          route6.c
>   Log:
>   cleanup use of m_tag.
>
>   Obtained from:  KAME
>
>   Revision  Changes    Path
>   1.21      +5 -20     src/sys/netinet6/frag6.c
> http://cvsweb.FreeBSD.org/src/sys/netinet6/frag6.c.diff?r1=1.20&r2=1.21
>   1.44      +37 -31    src/sys/netinet6/icmp6.c
> http://cvsweb.FreeBSD.org/src/sys/netinet6/icmp6.c.diff?r1=1.43&r2=1.44
>   1.60      +21 -21    src/sys/netinet6/ip6_input.c
> http://cvsweb.FreeBSD.org/src/sys/netinet6/ip6_input.c.diff?r1=1.59&r2=1.60
>   1.22      +2 -2      src/sys/netinet6/ip6_var.h
> http://cvsweb.FreeBSD.org/src/sys/netinet6/ip6_var.h.diff?r1=1.21&r2=1.22
>   1.9       +4 -3      src/sys/netinet6/route6.c
> http://cvsweb.FreeBSD.org/src/sys/netinet6/route6.c.diff?r1=1.8&r2=1.9

Half these changes (frag6.c and icmp6.c) are not tag related changes that I 
can see.  Can you please do a forced commit to indicate what the real point 
of the changes were?

As to the tag-related changes, I think they are a step backwards.  I did the 
original tag changes and intentionally hid the use of tags from the mainline 
IPv6 code to help KAME with portability between systems that used tags and 
those that use aux mbufs.  These changes expose the use of tags with no 
apparent advantage.

	Sam