From owner-freebsd-hackers@FreeBSD.ORG Mon Apr 20 16:45:15 2009 Return-Path: Delivered-To: hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0F671106567D; Mon, 20 Apr 2009 16:45:15 +0000 (UTC) (envelope-from shuvaev@physik.uni-wuerzburg.de) Received: from mailrelay.rz.uni-wuerzburg.de (mailrelay.rz.uni-wuerzburg.de [132.187.3.28]) by mx1.freebsd.org (Postfix) with ESMTP id 8D70D8FC24; Mon, 20 Apr 2009 16:45:14 +0000 (UTC) (envelope-from shuvaev@physik.uni-wuerzburg.de) Received: from virusscan.mail (localhost [127.0.0.1]) by mailrelay.mail (Postfix) with ESMTP id 16CCB1990C5; Mon, 20 Apr 2009 18:24:13 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by virusscan.mail (Postfix) with ESMTP id 08D1A1990BE; Mon, 20 Apr 2009 18:24:13 +0200 (CEST) Received: from mail.physik.uni-wuerzburg.de (wthp192.physik.uni-wuerzburg.de [132.187.40.192]) by mailmaster.uni-wuerzburg.de (Postfix) with ESMTP id E7E261990A2; Mon, 20 Apr 2009 18:24:12 +0200 (CEST) Received: from wep4035 ([132.187.37.35]) by mail.physik.uni-wuerzburg.de (Lotus Domino Release 8.0.2HF443) with ESMTP id 2009042018241234-4885 ; Mon, 20 Apr 2009 18:24:12 +0200 Received: by wep4035 (sSMTP sendmail emulation); Mon, 20 Apr 2009 18:24:11 +0200 Date: Mon, 20 Apr 2009 18:24:11 +0200 From: Alexey Shuvaev To: Roman Divacky Message-ID: <20090420162411.GA50951@wep4035.physik.uni-wuerzburg.de> References: <20090420084118.GA16337@freebsd.org> <49EC3E96.50208@fs.ei.tum.de> <20090420140219.GA74839@freebsd.org> MIME-Version: 1.0 In-Reply-To: <20090420140219.GA74839@freebsd.org> Organization: Universitaet Wuerzburg User-Agent: Mutt/1.5.18 (2008-05-17) X-MIMETrack: Itemize by SMTP Server on domino1/uni-wuerzburg(Release 8.0.2HF443 | November 25, 2008) at 04/20/2009 06:24:12 PM, Serialize by Router on domino1/uni-wuerzburg(Release 8.0.2HF443 | November 25, 2008) at 04/20/2009 06:24:12 PM, Serialize complete at 04/20/2009 06:24:12 PM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Virus-Scanned: by amavisd-new at uni-wuerzburg.de Cc: hackers@freebsd.org Subject: Re: [PATCH]: today highlighting in [n]cal X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Apr 2009 16:45:15 -0000 On Mon, Apr 20, 2009 at 04:02:19PM +0200, Roman Divacky wrote: > On Mon, Apr 20, 2009 at 11:21:26AM +0200, Simon 'corecode' Schubert wrote: > > Hey Roman, > > > > Roman Divacky wrote: > > >I made this patch that highlights today in cal/ncal just like gnu > > >cal does.. > > > > > > www.vlakno.cz/~rdivacky/cal.patch > > > > Thanks for this patch, I've been meaning to hack one up properly, but > > never got to it. They problems I was facing seem to exist also with your > > patch: > > > > - only works for wide (cal) mode, not ncal mode > > - probably won't work properly with year displays: the year printing > > parts of the code use a length argument to printf ("%*s"), which will > > confuse escape sequences with actual printed characters > > after addressing Simon's concerns here's a new patch: > > www.vlakno.cz/~rdivacky/cal2.patch > > this disables the highlighting for year printing because it's broken > and introduces the highlighting to ncal as well... > Nice! It depends on one more lib now: Modified: ~> ldd /usr/bin/ncal /usr/bin/ncal: libcalendar.so.4 => /usr/lib/libcalendar.so.4 (0x800643000) libncurses.so.7 => /lib/libncurses.so.7 (0x800745000) libc.so.7 => /lib/libc.so.7 (0x80088f000) Old: ~> ldd /home/jails/kde4/usr/bin/ncal /home/jails/kde4/usr/bin/ncal: libcalendar.so.4 => /usr/lib/libcalendar.so.4 (0x800642000) libc.so.7 => /lib/libc.so.7 (0x800744000) Does it work good in single user mode? (Don't want to go to it right now myself). OTOH, who needs cal/ncal in single user mode? :) Just my 0.02$, Alexey.