From owner-svn-ports-all@FreeBSD.ORG Thu May 14 16:07:29 2015 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A9A604F0 for ; Thu, 14 May 2015 16:07:29 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 884F61EB6 for ; Thu, 14 May 2015 16:07:29 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.9/8.14.9) with ESMTP id t4EG7T75010030 for ; Thu, 14 May 2015 16:07:29 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.9/8.14.9/Submit) id t4EG7Tgb010024 for svn-ports-all@freebsd.org; Thu, 14 May 2015 16:07:29 GMT (envelope-from bdrewery) Received: (qmail 16657 invoked from network); 14 May 2015 11:07:28 -0500 Received: from unknown (HELO ?10.10.1.139?) (freebsd@shatow.net@10.10.1.139) by sweb.xzibition.com with ESMTPA; 14 May 2015 11:07:28 -0500 Message-ID: <5554C841.7050309@FreeBSD.org> Date: Thu, 14 May 2015 11:07:29 -0500 From: Bryan Drewery Organization: FreeBSD User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Adam Weinberger , "Philip M. Gollucci" CC: "ports-committers@freebsd.org" , "svn-ports-all@freebsd.org" , "svn-ports-head@freebsd.org" Subject: Re: svn commit: r386285 - head/security/keychain References: <201505140101.t4E11r9T031351@svn.freebsd.org> <08F806A7-3CD9-417A-BA4E-AF739E83B6A8@adamw.org> <082DB80D-6385-4F4F-8A86-2DB4561E39E8@adamw.org> <5554C761.3060609@FreeBSD.org> In-Reply-To: <5554C761.3060609@FreeBSD.org> OpenPGP: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="8rQlNjD9oO7hAxJsN2Je3hcp73O0NwU88" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 May 2015 16:07:29 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8rQlNjD9oO7hAxJsN2Je3hcp73O0NwU88 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 5/14/2015 11:03 AM, Bryan Drewery wrote: > On 5/14/2015 11:00 AM, Adam Weinberger wrote: >>> On 13 May, 2015, at 21:20, Philip M. Gollucci = wrote: >>> >>> Then it needs an option not an if exists() >> >> Bryan, can you please consider reverting it, or giving me approval to = revert it? It may fix the case when the port is built in poudriere withou= t sshd in base, but it is a regression for everybody else. >> >> # Adam >> >> >=20 > No. The way RUN_DEPENDS is supposed to work is what I said in the > commit. These exists() checks are redundant and confuse the package > dependencies. >=20 > How are you building? It's possible the tool you are using is > incorrectly handling RUN_DEPENDS. >=20 Poudriere testport -i confirms this: > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > =3D=3D=3D> Building package for keychain-2.8.0_2 > actual-package-depends: dependency on /usr/bin/ssh-agent not registered= (normal if it belongs to base) =2E.. > root@exp-10amd64-commit-test:~ # pkg info | grep openssh > root@exp-10amd64-commit-test:~ # The ports framework, and poudriere, properly do not actually add this dependency and install it. Poudriere however does incorrectly *build* openssh-portable, but it won't add it as a real package run dependency. --=20 Regards, Bryan Drewery --8rQlNjD9oO7hAxJsN2Je3hcp73O0NwU88 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJVVMhBAAoJEDXXcbtuRpfPWlEH/1X8s4vrL+VBxFTA8DtFHFvz Gi1GeEJPIbLiFiXea1N9OgSG+/ndqADpzbXz3aQON9wU0Ig92rRw/qvz5Z7UlgwV cYe5hIHq8qgF6mU9ReXw/zsugF5ZdA3Xd+YLleXXsMDdqzw66bEPF4LaLmra40op iVfPSFk51DZkDd6RN67tEikshzr39Ri+EkGQ2ZUQNgn/MW0A45SAO6E7YxPhIzfr A1L4sYS5X8jiM0Eq30GCKQfzyZtxX5CLxXlETtjgSzlKXfOz3EKUO3tAPbXL8PCW RMvledyM29A6mZK9ChKA7ADlgXMITX4LL+MUHpTzhIRi/Rebk3rP0heYjRzlsLY= =atx0 -----END PGP SIGNATURE----- --8rQlNjD9oO7hAxJsN2Je3hcp73O0NwU88--