From owner-svn-ports-all@FreeBSD.ORG  Thu May 14 16:07:59 2015
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 15FE06C0;
 Thu, 14 May 2015 16:07:59 +0000 (UTC)
Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "abg.ninja", Issuer "Gandi Standard SSL CA 2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 88F0D1EC9;
 Thu, 14 May 2015 16:07:58 +0000 (UTC)
Received: by apnoea.adamw.org (OpenSMTPD) with ESMTPSA id 94ee3592;
 TLS version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO;
 Thu, 14 May 2015 10:07:57 -0600 (MDT)
Content-Type: text/plain; charset=windows-1252
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\))
Subject: Re: svn commit: r386285 - head/security/keychain
From: Adam Weinberger <adamw@adamw.org>
In-Reply-To: <5554C761.3060609@FreeBSD.org>
Date: Thu, 14 May 2015 10:07:55 -0600
Cc: "Philip M. Gollucci" <pgollucci@p6m7g8.com>,
 "ports-committers@freebsd.org" <ports-committers@freebsd.org>,
 "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>,
 "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <07ED759D-DFAC-44D0-A22B-1639EE3E0CB8@adamw.org>
References: <201505140101.t4E11r9T031351@svn.freebsd.org>
 <08F806A7-3CD9-417A-BA4E-AF739E83B6A8@adamw.org>
 <CACM2dAaFL6F-=mbfODTRrR83L+GeLfxzcM16DoroP1shmP6NHQ@mail.gmail.com>
 <082DB80D-6385-4F4F-8A86-2DB4561E39E8@adamw.org>
 <5554C761.3060609@FreeBSD.org>
To: Bryan Drewery <bdrewery@FreeBSD.org>
X-Mailer: Apple Mail (2.2098)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 14 May 2015 16:07:59 -0000

> On 14 May, 2015, at 10:03, Bryan Drewery <bdrewery@FreeBSD.org> wrote:
>=20
> On 5/14/2015 11:00 AM, Adam Weinberger wrote:
>>> On 13 May, 2015, at 21:20, Philip M. Gollucci <pgollucci@p6m7g8.com> =
wrote:
>>>=20
>>> Then it needs an option not an if exists()
>>=20
>> Bryan, can you please consider reverting it, or giving me approval to =
revert it? It may fix the case when the port is built in poudriere =
without sshd in base, but it is a regression for everybody else.
>>=20
>> # Adam
>>=20
>>=20
>=20
> No. The way RUN_DEPENDS is supposed to work is what I said in the
> commit. These exists() checks are redundant and confuse the package
> dependencies.
>=20
> How are you building? It's possible the tool you are using is
> incorrectly handling RUN_DEPENDS.

Ah! I see. It's portmaster that's doing the misbehaving. The problem is =
that openssh-portable still shows up in run-depends-list, and so =
portmaster decides that it is going to install openssh-portable first.

[root@apnoea /usr/ports/security/keychain] which ssh-agent
/usr/bin/ssh-agent
[root@apnoea /usr/ports/security/keychain] make run-depends-list
/usr/ports/security/openssh-portable
/usr/ports/shells/bash

# Adam


--=20
Adam Weinberger
adamw@adamw.org
http://www.adamw.org