From owner-freebsd-hackers@FreeBSD.ORG Fri Apr 26 02:56:47 2013 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id EE386640 for ; Fri, 26 Apr 2013 02:56:47 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-pa0-f49.google.com (mail-pa0-f49.google.com [209.85.220.49]) by mx1.freebsd.org (Postfix) with ESMTP id C9B1B1775 for ; Fri, 26 Apr 2013 02:56:47 +0000 (UTC) Received: by mail-pa0-f49.google.com with SMTP id kp14so2242480pab.36 for ; Thu, 25 Apr 2013 19:56:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=x-received:mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=5ii5YXQVLoqSKzTw/Ykr/np3H75onVdVTrXpVe++aE0=; b=cyq4Dln4EwJ557Fcg7ZB8sTkWd/6SHclxNs1Ft12e05roBQDUGgvGz5Q9vi8aTWQop K0P9lRW9uPai63m11swjH3MtxQZhewJxGQri2MhxjnR78UFenREtPZKtCOn1CFqB+lyq UZ50xPuP1KAWxLYqWzF4OmWItpBb/KuzGKmkE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type:x-gm-message-state; bh=5ii5YXQVLoqSKzTw/Ykr/np3H75onVdVTrXpVe++aE0=; b=EScTM5WGy2l8SMRRmckiRBNtc52gjE07hGItdMChMn2jWr+chBoHdvnBkJJjvujkX0 kdl3IsxYTV/T5iZUYKDG+0mX/RP5soP9Zx29HVyGDNKFbBj16j2Ho7FJ+exenE5fY2h8 08gDdW/cF0/zI4jESNBPN8yZjZolsNj878Ila4WSx0aKVRWvEoz6BiBfqJ5q68sKqo5i srq4mEUU/X+K8fWcL7VYhE6fgTwpt52C/d8Y+4nR4UZxsqdCbIYOK9WXvv456k5VbUZc 1y9OT3wy2t1viCWFbIeg2+bduW9ef3xa/xsRIj4GdWzUSyGoukPUtd1jnPtiEAY+Apy0 bGzw== X-Received: by 10.66.118.142 with SMTP id km14mr27667302pab.129.1366945000871; Thu, 25 Apr 2013 19:56:40 -0700 (PDT) MIME-Version: 1.0 Received: by 10.66.159.97 with HTTP; Thu, 25 Apr 2013 19:56:10 -0700 (PDT) In-Reply-To: <20130426025049.GC50623@lor.one-eyed-alien.net> References: <20130426025049.GC50623@lor.one-eyed-alien.net> From: Eitan Adler Date: Thu, 25 Apr 2013 22:56:10 -0400 Message-ID: Subject: Re: Some improvements to rm(1) To: Brooks Davis Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQkh8gj4Ajccb3yWs9R62CUCJDjv2V6sqQ+BBtdRye8wGR3p6fmK4LUQa2+ruLGyZSmkEBCI Cc: FreeBSD Hackers X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Apr 2013 02:56:48 -0000 On 25 April 2013 22:50, Brooks Davis wrote: > On Thu, Apr 25, 2013 at 10:16:32PM -0400, Eitan Adler wrote: >> Anyone have thoughts on the following? >> >> commit 82c78ba923d8ce4a1bfbb309658c49021c8bb384 >> Author: Eitan Adler >> Date: Thu Apr 25 22:14:49 2013 -0400 >> >> Take some improvements from DragonFlyBSD: >> - add const where appropriate >> - add static where appropriate >> - fix a whitespace issues > > The no-op changes look more correct to me. > > I think the -x option seems a bit odd. What is the use case? At a > first thought, it seems to raise more questions than it resolves. It goes along with cp -x, find -x, and others. Quick example #1: You have /usr/ports /usr/ports/distfiles as different mount points it lets you wipe /usr/ports without wiping your distfile cache. Quick example #2: You have /usr/src/ null mounted in every user's /home/ and you want to wipe one home directory. -- Eitan Adler