From owner-p4-projects  Mon Nov 18 10: 7:15 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 3D8E237B401; Mon, 18 Nov 2002 10:07:14 -0800 (PST)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C4B1F37B404
	for <perforce@FreeBSD.org>; Mon, 18 Nov 2002 10:07:13 -0800 (PST)
Received: from mail.speakeasy.net (mail14.speakeasy.net [216.254.0.214])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A46DE43E88
	for <perforce@FreeBSD.org>; Mon, 18 Nov 2002 10:07:12 -0800 (PST)
	(envelope-from jhb@FreeBSD.org)
Received: (qmail 5783 invoked from network); 18 Nov 2002 18:07:17 -0000
Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63])
          (envelope-sender <jhb@FreeBSD.org>)
          by mail14.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP
          for <green@FreeBSD.org>; 18 Nov 2002 18:07:17 -0000
Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1])
	by server.baldwin.cx (8.12.6/8.12.6) with ESMTP id gAII7A2D027516;
	Mon, 18 Nov 2002 13:07:11 -0500 (EST)
	(envelope-from jhb@FreeBSD.org)
Message-ID: <XFMail.20021118130715.jhb@FreeBSD.org>
X-Mailer: XFMail 1.5.2 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <Pine.NEB.3.96L.1021115191246.62811D-100000@fledge.watson.org>
Date: Mon, 18 Nov 2002 13:07:15 -0500 (EST)
From: John Baldwin <jhb@FreeBSD.org>
To: Robert Watson <rwatson@FreeBSD.org>
Subject: Re: PERFORCE change 21079 for review
Cc: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: Perforce Change Reviews <perforce@FreeBSD.org>,
	Brian Feldman <green@FreeBSD.org>
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG


On 16-Nov-2002 Robert Watson wrote:
> On Fri, 15 Nov 2002, Brian Feldman wrote:
>>  int
>> +mac_check_system_kldload(struct ucred *cred, struct vnode *vp)
>> +{
>> +    int error;
>> +
>> +    if (vp != NULL) {
>> +            ASSERT_VOP_LOCKED(vp, "mac_check_system_acct");
>> +    }
> 
> Two questions:
> 
> (2) Looks like a copy-and-paste-o: should be kldload not acct.

__func__ > manually making copies of all function names.

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message