From owner-cvs-all@FreeBSD.ORG  Sat Nov  8 01:55:17 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id B890416A4CE; Sat,  8 Nov 2003 01:55:17 -0800 (PST)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 4BB7A43F93; Sat,  8 Nov 2003 01:55:17 -0800 (PST)
	(envelope-from bde@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.9/8.12.9) with ESMTP id hA89tHXJ048749;
	Sat, 8 Nov 2003 01:55:17 -0800 (PST)
	(envelope-from bde@repoman.freebsd.org)
Received: (from bde@localhost)
	by repoman.freebsd.org (8.12.9/8.12.9/Submit) id hA89tGiP048748;
	Sat, 8 Nov 2003 01:55:16 -0800 (PST)
	(envelope-from bde)
Message-Id: <200311080955.hA89tGiP048748@repoman.freebsd.org>
From: Bruce Evans <bde@FreeBSD.org>
Date: Sat, 8 Nov 2003 01:55:16 -0800 (PST)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org,
	cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Subject: cvs commit: src/bin/rm rm.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 08 Nov 2003 09:55:17 -0000

bde         2003/11/08 01:55:16 PST

  FreeBSD src repository

  Modified files:
    bin/rm               rm.c 
  Log:
  1. Fixed leakage of a file descriptor for every non-fatal failure in
     rm_overwrite() (for rm -P).
  
  2. Print the file name in the error message for (fatal) malloc() failures
     in rm_overwrite().  I first thought that malloc() failures should be
     non-fatal since they don't prevent proceeding the the next file, but
     making them non-fatal would normally give too much output for rm -Pr
     on a large tree in the unlikely event that even one occurs, since the
     malloc()ed amounts are usually the same.  Just print the file name since
     the malloc()ed amounts are not always the same and it doesn't hurt to
     know where rm was when it quit.
  
  Submitted by:   guido ((1) and original version of (2))
  
  Revision  Changes    Path
  1.44      +3 -1      src/bin/rm/rm.c