From owner-p4-projects  Tue Nov 19  7:46:21 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 363B237B481; Tue, 19 Nov 2002 07:46:13 -0800 (PST)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C640237B406
	for <perforce@freebsd.org>; Tue, 19 Nov 2002 07:46:12 -0800 (PST)
Received: from mail.speakeasy.net (mail16.speakeasy.net [216.254.0.216])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1053D43E3B
	for <perforce@freebsd.org>; Tue, 19 Nov 2002 07:46:12 -0800 (PST)
	(envelope-from jhb@FreeBSD.org)
Received: (qmail 4929 invoked from network); 19 Nov 2002 15:46:13 -0000
Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63])
          (envelope-sender <jhb@FreeBSD.org>)
          by mail16.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP
          for <perforce@freebsd.org>; 19 Nov 2002 15:46:13 -0000
Received: from laptop.baldwin.cx (laptop.baldwin.cx [192.168.0.4])
	by server.baldwin.cx (8.12.6/8.12.6) with ESMTP id gAJFk22D030798;
	Tue, 19 Nov 2002 10:46:02 -0500 (EST)
	(envelope-from jhb@FreeBSD.org)
Message-ID: <XFMail.20021119104607.jhb@FreeBSD.org>
X-Mailer: XFMail 1.5.2 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <200211190735.gAJ7ZMDS059613@repoman.freebsd.org>
Date: Tue, 19 Nov 2002 10:46:07 -0500 (EST)
From: John Baldwin <jhb@FreeBSD.org>
To: Juli Mallett <jmallett@FreeBSD.org>
Subject: RE: PERFORCE change 21259 for review
Cc: Perforce Change Reviews <perforce@freebsd.org>
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG


On 19-Nov-2002 Juli Mallett wrote:
> http://perforce.freebsd.org/chv.cgi?CH=21259
> 
> Change 21259 by jmallett@jmallett_luna on 2002/11/18 23:35:03
> 
>       Too much unatomic clutter.  Fill in atomic_set_{int,long}, as
>       they're the basis for most everything else, and other stuff can
>       be added as it's actually needed.

Uh, you do know that atomic_set are actually OR-operations, not assignment.
Right?  Also, your operations do not look atomic as it seems to be a three
instruction sequence of load/modify/store.  Imagine an interrupt coming in
in between the load and store.

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message