From owner-cvs-src@FreeBSD.ORG Mon Jan 16 17:03:21 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C70D916A451; Mon, 16 Jan 2006 17:03:21 +0000 (GMT) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7ACB543D48; Mon, 16 Jan 2006 17:03:21 +0000 (GMT) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k0GH3LD6011188; Mon, 16 Jan 2006 17:03:21 GMT (envelope-from csjp@repoman.freebsd.org) Received: (from csjp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k0GH3LTP011187; Mon, 16 Jan 2006 17:03:21 GMT (envelope-from csjp) Message-Id: <200601161703.k0GH3LTP011187@repoman.freebsd.org> From: "Christian S.J. Peron" Date: Mon, 16 Jan 2006 17:03:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netsmb smb_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jan 2006 17:03:22 -0000 csjp 2006-01-16 17:03:21 UTC FreeBSD src repository Modified files: sys/netsmb smb_subr.c Log: Although we check the return value of copyin(9) while determaining how long the string is in userspace, afterwards we call malloc(M_WAITOK), which could sleep for an unknown amount of time. Check the return value of copyin(9) just to be sure that nothing has changed during that time. Found with: Coverity Prevent (tm) MFC after: 1 week Revision Changes Path 1.20 +6 -2 src/sys/netsmb/smb_subr.c