From owner-svn-src-all@freebsd.org Wed May 18 22:14:28 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CB2BDB418BE for ; Wed, 18 May 2016 22:14:28 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from pmta2.delivery6.ore.mailhop.org (pmta2.delivery6.ore.mailhop.org [54.200.129.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8FEB213B5 for ; Wed, 18 May 2016 22:14:28 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: f2c54992-1d45-11e6-a09e-4d61a6885157 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 73.34.117.227 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [73.34.117.227]) by outbound2.ore.mailhop.org (Halon Mail Gateway) with ESMTPSA; Wed, 18 May 2016 22:14:54 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.14.9) with ESMTP id u4IMEP6n053621; Wed, 18 May 2016 16:14:25 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1463609665.1180.301.camel@freebsd.org> Subject: Re: svn commit: r300167 - in head: contrib/bsnmp/snmpd usr.sbin/bsnmpd/bsnmpd From: Ian Lepore To: Gleb Smirnoff , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Wed, 18 May 2016 16:14:25 -0600 In-Reply-To: <201605182202.u4IM2JF7047307@repo.freebsd.org> References: <201605182202.u4IM2JF7047307@repo.freebsd.org> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.16.5 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 May 2016 22:14:28 -0000 On Wed, 2016-05-18 at 22:02 +0000, Gleb Smirnoff wrote: > Author: glebius > Date: Wed May 18 22:02:19 2016 > New Revision: 300167 > URL: https://svnweb.freebsd.org/changeset/base/300167 > > Log: > Revert r299830, it has couple of fatal errors. > > The CMSG_ family of macros take care of alignment, so we don't need > r299830 > at all, even if it was correct. Put NO_WCAST_ALIGN into Makefile. > So all of this was about a "cast increases required alignment" kind of warning for a macro that takes care of alignment? Wouldn't the proper fix then be to change CMSG_DATA() so that its internal cast is void* instead of unsigned char* (he asked, knowing Bruce would come along soon and point out why that's a dumb question)? -- Ian