From owner-svn-src-all@FreeBSD.ORG Mon May 12 16:04:44 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D3422A5F for ; Mon, 12 May 2014 16:04:44 +0000 (UTC) Received: from mail-lb0-f173.google.com (mail-lb0-f173.google.com [209.85.217.173]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 194C724FC for ; Mon, 12 May 2014 16:04:42 +0000 (UTC) Received: by mail-lb0-f173.google.com with SMTP id 10so7684351lbg.18 for ; Mon, 12 May 2014 09:04:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=ePyOGXwqk2Sg6GOVBv6nvLadOso/nzhd7O4Wvl0deP4=; b=Xas4BtFrdyBwHJ1XztcffQcpkyeIN3fFNmoQi7bNscSn+7lVKpyaz+8pTWdWcykzB7 SkQDiLbP4X6ghgoHFr5b81vBZg6poeW8FAeunjNTi38IO9xqOj/1aiuBhYoszQBpCjdn OppytQZ8KK6MpBma//5Gu0M7Xm+144jQGQoiEYbDqRyyw3BkhBrYhdGCNiY9ePafzXXL tu7ugXojEGECwZWFzWJ51f8x0tj/Tb+8pZysU4Go06c4U3ae7/ZKuePKdz95R9DI2Hnd Gr5o5rY1ki53k8HcWl4epMUmASbCN0I9SGr7FbmH1tuI90O60oJICQLg6FvTllkK3Gox UKiw== X-Gm-Message-State: ALoCoQk8kdEHyxAHl3jxgJOBLMXLlFsbACxmBqEwwrntRbLfvTRXgWU+t1Ne6EiOsGSo06EvmyHh X-Received: by 10.152.242.164 with SMTP id wr4mr2648861lac.38.1399910674390; Mon, 12 May 2014 09:04:34 -0700 (PDT) Received: from [192.168.1.2] ([89.169.173.68]) by mx.google.com with ESMTPSA id dl4sm14239640lbc.4.2014.05.12.09.04.33 for (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 12 May 2014 09:04:33 -0700 (PDT) Message-ID: <5370F110.5050502@freebsd.org> Date: Mon, 12 May 2014 20:04:32 +0400 From: Andrey Chernov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Don Lewis , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org Subject: Re: svn commit: r265901 - stable/10/sys/kern References: <201405120427.s4C4RAZf093033@svn.freebsd.org> In-Reply-To: <201405120427.s4C4RAZf093033@svn.freebsd.org> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 May 2014 16:04:44 -0000 On 12.05.2014 8:27, Don Lewis wrote: > + if (start + amask < start) { > + DPRINTF(("start+amask wrapped around\n")); > + goto out; > + } Checking for overflow _after_ it happens is unportable and dangerous, since wrapping around is not only one possible result. They should be rewritten like that: if (start > ULONG_MAX - amask) -- http://ache.vniz.net/