From owner-svn-ports-all@FreeBSD.ORG  Thu Dec 26 22:41:23 2013
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 3F4A2594;
 Thu, 26 Dec 2013 22:41:23 +0000 (UTC)
Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 58EA21855;
 Thu, 26 Dec 2013 22:41:22 +0000 (UTC)
Received: from [192.168.1.113] (c-174-61-88-207.hsd1.fl.comcast.net
 [174.61.88.207])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by shepard.synsport.net (Postfix) with ESMTP id BBD72435C7;
 Thu, 26 Dec 2013 16:41:09 -0600 (CST)
Message-ID: <52BCB084.3040504@marino.st>
Date: Thu, 26 Dec 2013 23:41:08 +0100
From: John Marino <freebsd.contact@marino.st>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:17.0) Gecko/20130509 Thunderbird/17.0.6
MIME-Version: 1.0
To: Baptiste Daroussin <bapt@FreeBSD.org>
Subject: Re: svn commit: r337624 - head/games/daimonin-music
References: <201312262215.rBQMF1ZF002032@svn.freebsd.org>
 <20131226223743.GV40122@ithaqua.etoilebsd.net>
In-Reply-To: <20131226223743.GV40122@ithaqua.etoilebsd.net>
X-Enigmail-Version: 1.6
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 Eitan Adler <eadler@freebsd.org>, ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
Reply-To: marino@freebsd.org
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Dec 2013 22:41:23 -0000

On 12/26/2013 23:37, Baptiste Daroussin wrote:
> On Thu, Dec 26, 2013 at 10:15:01PM +0000, John Marino wrote:
>> Author: marino
>> Date: Thu Dec 26 22:15:01 2013
>> New Revision: 337624
>> URL: http://svnweb.freebsd.org/changeset/ports/337624
>>
> The port itself is still wrong, NO_CHECKSUM is still being used, while
> bsd.port.mk specifically says it is not to be used inside a port, so this should
> either be fixed or the port should remain broken.
> 

I saw later this PR: http://www.freebsd.org/cgi/query-pr.cgi?pr=170052

It is taken by eadler@.  The patch itself is no longer good but at least
there was some attempt to fix it.  I did not know NO_CHECKSUM was
internal use only.  It built fine in poudriere, which is where I tested
it.  Is eadler going to follow up?  or at least release the PR?

John