From owner-freebsd-current@FreeBSD.ORG Mon Jul 9 04:13:40 2007 Return-Path: X-Original-To: freebsd-current@FreeBSD.org Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D9AAD16A400; Mon, 9 Jul 2007 04:13:40 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id 4D14A13C468; Mon, 9 Jul 2007 04:13:39 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l694Dca4097527; Mon, 9 Jul 2007 08:13:38 +0400 (MSD) (envelope-from ache@nagual.pp.ru) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nagual.pp.ru; s=default; t=1183954418; bh=DailEOU/EkCDg2HhRLlRvnJh1HmEsB+JCjaiyR3 dHLM=; l=442; h=Received:Date:From:To:Cc:Subject:Message-ID: Mail-Followup-To:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To:User-Agent; b=ZAD0/UC1VRV2p+3VDgNs kgIJJaDOndWUulvG9VGIP52m45dOblNtBUJXgLkauepsh3HaqCOlF+zSQtOVSEVlFzO 4JuiOlejOEZ4/UT5rSXsloVdKw/Ws4ORIO+ffLH/JF8g5cYIvm755b5spuFzQQQOweY TT7pgcoT7BMXmxqvA= Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l694Dc41097526; Mon, 9 Jul 2007 08:13:38 +0400 (MSD) (envelope-from ache) Date: Mon, 9 Jul 2007 08:13:37 +0400 From: Andrey Chernov To: "Sean C. Farley" Message-ID: <20070709041337.GA97347@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , "Sean C. Farley" , Robert Watson , freebsd-current , Michal Mertl References: <20070707130859.GA96605@nagual.pp.ru> <20070707131359.GB96605@nagual.pp.ru> <20070707133102.C14065@thor.farley.org> <20070707191835.GA4368@nagual.pp.ru> <20070707205410.B14065@thor.farley.org> <20070708020940.GA80166@nagual.pp.ru> <20070708171727.GA90490@nagual.pp.ru> <20070708125905.F14065@thor.farley.org> <20070708183823.GA91359@nagual.pp.ru> <20070708203635.A14065@thor.farley.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070708203635.A14065@thor.farley.org> User-Agent: Mutt/1.5.16 (2007-06-09) Cc: freebsd-current , Robert Watson , Michal Mertl Subject: Re: Environment handling broken in /bin/sh with changes to {get,set,put}env() X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jul 2007 04:13:40 -0000 On Sun, Jul 08, 2007 at 08:40:11PM -0500, Sean C. Farley wrote: > > Your interpretation of the specification is correct. My latest patch > should apply. I changed getenv() to never change environ. If it > detects that environ was replaced, it falls back to returning the value > from there. Only setenv(), unsetenv() and putenv() will alter environ. > How does it look to you? Ok now. No suggestions left. -- http://ache.pp.ru/