From owner-freebsd-bugs@freebsd.org Sun Aug 16 16:51:33 2015 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 61A6A9BBDB2 for ; Sun, 16 Aug 2015 16:51:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 481D01610 for ; Sun, 16 Aug 2015 16:51:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id t7GGpXP0049099 for ; Sun, 16 Aug 2015 16:51:33 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 202365] [patch] [geli] Consider improving PBKDF2 performance Date: Sun, 16 Aug 2015 16:51:33 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: jpixton@gmail.com X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status keywords bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Aug 2015 16:51:33 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202365 Bug ID: 202365 Summary: [patch] [geli] Consider improving PBKDF2 performance Product: Base System Version: 11.0-CURRENT Hardware: Any OS: Any Status: New Keywords: patch Severity: Affects Some People Priority: --- Component: kern Assignee: freebsd-bugs@FreeBSD.org Reporter: jpixton@gmail.com Keywords: patch Created attachment 159924 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=159924&action=edit proposed patch The PBKDF2 in sys/geom/eli/pkcs5v2.c is around half the speed than it could be. I have some background on this issue on my blog[1]. I've attached a patch which does the minimum needed changes. This processes the HMAC key (in PBKDF2, the password) once, and then uses this as a starting point for all the subsequent computations. - For existing volumes, this should roughly double the mounting speed (measured as 51% of previous on my machine). - For new volumes it should approximately double the security margin (measured as 196% of previous on my machine). Cheers, Joe [1]: https://jbp.io/2015/08/11/pbkdf2-performance-matters/ -- You are receiving this mail because: You are the assignee for the bug.