From owner-freebsd-ports-bugs@FreeBSD.ORG  Fri Mar 24 05:17:29 2006
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
X-Original-To: freebsd-ports-bugs@FreeBSD.org
Delivered-To: freebsd-ports-bugs@FreeBSD.org
Received: by hub.freebsd.org (Postfix, from userid 1035)
	id D8F6316A401; Fri, 24 Mar 2006 05:17:29 +0000 (UTC)
Date: Fri, 24 Mar 2006 05:17:29 +0000
From: Xin LI <delphij@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org, freebsd-ports-bugs@FreeBSD.org
Message-ID: <20060324051729.GA35108@hub.freebsd.org>
References: <200603201024.k2KAOIB3039118@tarsier.delphij.net>
	<200603201030.k2KAUGri078554@freefall.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200603201030.k2KAUGri078554@freefall.freebsd.org>
User-Agent: Mutt/1.4.2.1i
Cc: 
Subject: Re: ports/94725: [PATCH] Update net/py-ldap2 to 2.0.11
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 24 Mar 2006 05:17:29 -0000

Additionally this patch should be placed into files/ directory in
order to elminate a memory leak:

Index: LDAPObject.c
===================================================================
RCS file: /cvsroot/python-ldap/python-ldap/Modules/LDAPObject.c,v
retrieving revision 1.72
diff -u -r1.72 LDAPObject.c
--- Modules/LDAPObject.c	11 Mar 2006 21:05:57 -0000	1.72
+++ Modules/LDAPObject.c	23 Mar 2006 21:48:33 -0000
@@ -971,8 +971,16 @@
     if (pmsg == NULL) {
 	    retval = NULL;
     } else {
-        retval = Py_BuildValue("(OOiO)", result_str, pmsg, res_msgid,
-			       pyctrls ? pyctrls : PyList_New(0));
+	if (pyctrls != NULL) {
+        	retval = Py_BuildValue("(OOiO)", result_str, pmsg, res_msgid,
+				       pyctrls);
+	} else { 
+		PyObject *pNewList = PyList_New(0);
+        	retval = Py_BuildValue("(OOiO)", result_str, pmsg, res_msgid,
+				       pNewList);
+		Py_DECREF(pNewList);
+	}
+
 	if (pmsg != Py_None) {
         Py_DECREF(pmsg);
     }


Note that this patch was submitted to the original author but got
response.

Cheers,