From owner-freebsd-hackers Tue Aug 17 9:20:30 1999 Delivered-To: freebsd-hackers@freebsd.org Received: from marcy.nas.nasa.gov (marcy.nas.nasa.gov [129.99.113.17]) by hub.freebsd.org (Postfix) with ESMTP id 9B5BE1503B; Tue, 17 Aug 1999 09:20:27 -0700 (PDT) (envelope-from wrstuden@marcy.nas.nasa.gov) Received: from localhost (wrstuden@localhost) by marcy.nas.nasa.gov (8.9.3/NAS8.8.7) with SMTP id JAA08787; Tue, 17 Aug 1999 09:20:29 -0700 (PDT) Date: Tue, 17 Aug 1999 09:20:29 -0700 (PDT) From: Bill Studenmund To: Michael Hancock Cc: Hackers@FreeBSD.ORG, fs@FreeBSD.ORG Subject: Re: BSD XFS Port & BSD VFS Rewrite In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Tue, 17 Aug 1999, Michael Hancock wrote: > As I recall most of FBSD's default routines are also error routines, if > the exceptions were a problem it would would be trivial to fix. > > I think fixing resource allocation/deallocation for things like vnodes, > cnbufs, and locks are a higher priority for now. There are examples such > as in detached threading where it might make sense for the detached child > to be responsible for releasing resources allocated to it by the parent, > but in stacking this model is very messy and unnatural. This is why the > purpose of VOP_ABORTOP appears to be to release cnbufs but this is really > just an ugly side effect. With stacking the code that allocates should be > the code that deallocates. Substitute, "code" with "layer" to be more > correct. > > I fixed a lot of the vnode and locking cases, unfortunately the ones that > remain are probably ugly cases where you have to reacquire locks that had > to be unlocked somewhere in the executing layer. See VOP_RENAME for an > example. Compare the number of WILLRELEs in vnode_if.src in FreeBSD and > NetBSD, ideally there'd be none. I've compared the two, and making the NetBSD number match the FreeBSD number is one of my goals. :-) Any suggestions, or just plod&fix? Take care, Bill To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message