From owner-freebsd-hackers@FreeBSD.ORG Thu Jan 24 19:52:39 2013 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 88C6CC43; Thu, 24 Jan 2013 19:52:39 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id 66EBC13D; Thu, 24 Jan 2013 19:52:39 +0000 (UTC) Received: from pakbsde14.localnet (unknown [38.105.238.108]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id D90B8B94B; Thu, 24 Jan 2013 14:52:38 -0500 (EST) From: John Baldwin To: Mikolaj Golub Subject: Re: libprocstat(3): retrieve process command line args and environment Date: Thu, 24 Jan 2013 11:20:51 -0500 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p22; KDE/4.5.5; amd64; ; ) References: <20130119151253.GB88025@gmail.com> <201301231131.43972.jhb@freebsd.org> <20130123214949.GA3120@gmail.com> In-Reply-To: <20130123214949.GA3120@gmail.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201301241120.52054.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Thu, 24 Jan 2013 14:52:38 -0500 (EST) Cc: Stanislav Sedov , freebsd-hackers@freebsd.org, Robert Watson X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jan 2013 19:52:39 -0000 On Wednesday, January 23, 2013 4:49:50 pm Mikolaj Golub wrote: > On Wed, Jan 23, 2013 at 11:31:43AM -0500, John Baldwin wrote: > > On Wednesday, January 23, 2013 2:25:00 am Mikolaj Golub wrote: > > > IMHO, after adding procstat_getargv and procstat_getargv, the usage of > > > kvm_getargv() and kvm_getenvv() (at least in the new code) may be > > > deprecated. As this is stated in the man page, BUGS section, "these > > > routines do not belong in the kvm interface". I suppose they are part > > > of libkvm because there was no a better place for them. procstat(1) > > > prefers direct sysctl to them (so, again, code duplication, which I am > > > going to remove adding procstat_getargv/envv). > > > > Hmm, are you going to rewrite ps(1) to use libprocstat? Or rather, is that a > > goal someday? That is one current consumer of kvm_getargv/envv. That might > > be fine if we want to make more tools use libprocstat instead of using libkvm > > directly. > > I didn't have any plans for ps(1) :-) That is why I wrote about "new > code". But if you think it is good to do I might look at it one day... I'm mostly hoping Robert chimes in to see if that was his intention for libprocstat. :) If we can ultimately replace all uses of kvm_get*v() with calls to procstat_get*v*() then I'm fine with some code duplication in the interim. -- John Baldwin