From owner-freebsd-current@FreeBSD.ORG  Wed Jan  5 13:12:56 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 1B02F16A4CE; Wed,  5 Jan 2005 13:12:56 +0000 (GMT)
Received: from kane.otenet.gr (kane.otenet.gr [195.170.0.27])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 46F5F43D46; Wed,  5 Jan 2005 13:12:55 +0000 (GMT)
	(envelope-from keramida@freebsd.org)
Received: from orion.daedalusnetworks.priv (aris.bedc.ondsl.gr
	[62.103.39.226])j05DCr6s010911;	Wed, 5 Jan 2005 15:12:54 +0200
Received: from orion.daedalusnetworks.priv (orion [127.0.0.1])
	j05DCrPs015400;	Wed, 5 Jan 2005 15:12:53 +0200 (EET)
	(envelope-from keramida@freebsd.org)
Received: (from keramida@localhost)j05DCr06015397;
	Wed, 5 Jan 2005 15:12:53 +0200 (EET)
	(envelope-from keramida@freebsd.org)
Date: Wed, 5 Jan 2005 15:12:53 +0200
From: Giorgos Keramidas <keramida@freebsd.org>
To: freebsd-current@freebsd.org, Julian Elischer <julian@freebsd.org>
Message-ID: <20050105131253.GA12430@orion.daedalusnetworks.priv>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Subject: RFC: Inverse KASSERT in sys/dev/usb/ohci.c:1.150 ?
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Jan 2005 13:12:56 -0000

The KASSERT that replaces an explicit if conditional in ohci.c:1.150
causes a panic here when I try to use my USB flash disk:

% -#ifdef DIAGNOSTIC
% -                        if (curlen == 0)
% -                                panic("ohci_alloc_std: curlen == 0");
% -#endif
% +                        KASSERT ((curlen == 0), ("ohci_alloc_std: curlen == 0"));

Shouldn't the KASSERT expression have inverse logic, i.e.:

	KASSERT((curlen != 0), ("ohci_alloc_std: curlen == 0"));

- Giorgos