From owner-svn-src-all@FreeBSD.ORG  Wed May 14 08:38:11 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 44216BE6;
 Wed, 14 May 2014 08:38:11 +0000 (UTC)
Received: from alchemy.franken.de (alchemy.franken.de [194.94.249.214])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "alchemy.franken.de", Issuer "alchemy.franken.de" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id CC62C2846;
 Wed, 14 May 2014 08:38:10 +0000 (UTC)
Received: from alchemy.franken.de (localhost [127.0.0.1])
 by alchemy.franken.de (8.14.8/8.14.8/ALCHEMY.FRANKEN.DE) with ESMTP id
 s4E8c1Rn029991
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Wed, 14 May 2014 10:38:01 +0200 (CEST)
 (envelope-from marius@alchemy.franken.de)
Received: (from marius@localhost)
 by alchemy.franken.de (8.14.8/8.14.8/Submit) id s4E8c1K8029990;
 Wed, 14 May 2014 10:38:01 +0200 (CEST) (envelope-from marius)
Date: Wed, 14 May 2014 10:38:01 +0200
From: Marius Strobl <marius@alchemy.franken.de>
To: Hans Petter Selasky <hselasky@FreeBSD.org>
Subject: Re: svn commit: r266006 - head/sys/modules/sound/driver/uaudio
Message-ID: <20140514083801.GC679@alchemy.franken.de>
References: <201405140733.s4E7X6Ux080638@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201405140733.s4E7X6Ux080638@svn.freebsd.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3
 (alchemy.franken.de [0.0.0.0]); Wed, 14 May 2014 10:38:02 +0200 (CEST)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 14 May 2014 08:38:11 -0000

On Wed, May 14, 2014 at 07:33:06AM +0000, Hans Petter Selasky wrote:
> Author: hselasky
> Date: Wed May 14 07:33:06 2014
> New Revision: 266006
> URL: http://svnweb.freebsd.org/changeset/base/266006
> 
> Log:
>   Change the USB audio kernel module linking order, so that the USB
>   audio device driver is detached first and not its children. This fixes
>   a panic in some cases when unloading "snd_uaudio" while a USB device
>   is plugged. The linking order affects the order in which the module
>   dependencies are registered.

The right way of specifying that uaudio should be registered last, i. e.
after other device drivers employing DRIVER_MODULE(), would be using:
DRIVER_MODULE_ORDER(uaudio, uhub, uaudio_driver, uaudio_devclass, NULL, NULL,
    SI_ORDER_ANY);
instead of the existing DRIVER_MODULE() in uaudio.c.

Marius