From owner-freebsd-current@FreeBSD.ORG Tue Jun 3 08:44:12 2008 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 861821065673 for ; Tue, 3 Jun 2008 08:44:12 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from rv-out-0506.google.com (rv-out-0506.google.com [209.85.198.231]) by mx1.freebsd.org (Postfix) with ESMTP id 486708FC22 for ; Tue, 3 Jun 2008 08:44:12 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: by rv-out-0506.google.com with SMTP id b25so1529103rvf.43 for ; Tue, 03 Jun 2008 01:44:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:received:date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; bh=bB/w2EOE/zUySHw8EottmLKpACP8Dg6eOCtQz806QMs=; b=Oi2cjIPM6bTxEDyNF4Ou6JZud37G9WTVNMxDTZxiVyoK9WENPW1FItk9c3X2Sr8DDFrSR6T7A58vxF+cWUTijJb9kyv3R03yHgOobk5y3f23a1HJcMl/sGYYrY2CUopI9tT2UGVvLGel5OTnUM8c6lQKrc1e8t+gfQWZq7Y/pP4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=Ll+KU3xsG3miAGUL1C7IvzJHLeuOIkisWZkXRz87Y1OBw2SQPbV/8KslC410dFJSQfywLHDuPJLM3wZU/NuwVrhIfjO3uxXrso4kfMGkqxfIGNdtGncRXYIQubd6OXcG8ptTy3+CrrPmpQdGh5RktXnC83QCOAKGrXMbgdT3d6E= Received: by 10.141.66.16 with SMTP id t16mr5593879rvk.168.1212482651724; Tue, 03 Jun 2008 01:44:11 -0700 (PDT) Received: from michelle.cdnetworks.co.kr ( [211.53.35.84]) by mx.google.com with ESMTPS id g31sm7829314rvb.2.2008.06.03.01.44.08 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 03 Jun 2008 01:44:10 -0700 (PDT) Received: from michelle.cdnetworks.co.kr (localhost.cdnetworks.co.kr [127.0.0.1]) by michelle.cdnetworks.co.kr (8.13.5/8.13.5) with ESMTP id m538i597089244 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 3 Jun 2008 17:44:05 +0900 (KST) (envelope-from pyunyh@gmail.com) Received: (from yongari@localhost) by michelle.cdnetworks.co.kr (8.13.5/8.13.5/Submit) id m538i4fa089243; Tue, 3 Jun 2008 17:44:04 +0900 (KST) (envelope-from pyunyh@gmail.com) Date: Tue, 3 Jun 2008 17:44:04 +0900 From: Pyun YongHyeon To: Norikatsu Shigemura Message-ID: <20080603084404.GB87699@cdnetworks.co.kr> References: <20080602034630.eb07fe5c.nork@FreeBSD.org> <20080602003948.GA83841@cdnetworks.co.kr> <20080603011316.7736c782.nork@FreeBSD.org> <20080603010001.GA87699@cdnetworks.co.kr> <20080603134425.e78589b5.nork@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="1LKvkjL3sHcu1TtY" Content-Disposition: inline In-Reply-To: <20080603134425.e78589b5.nork@FreeBSD.org> User-Agent: Mutt/1.4.2.1i Cc: Bill Paul , freebsd-current@FreeBSD.org, Sam Leffler Subject: Re: axe(4) doesn't work (patch to replace obsolete if_watchdog interface) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jun 2008 08:44:12 -0000 --1LKvkjL3sHcu1TtY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 03, 2008 at 01:44:25PM +0900, Norikatsu Shigemura wrote: > On Tue, 3 Jun 2008 10:00:01 +0900 > Pyun YongHyeon wrote: > > > ukphy0: OUI 0x1e525e, model 0x0014, rev. 9 > > ^^^^^^^^^^^^ > > This OUI does not exist in IEEE OUI database so I vaguely guess > > this one comes from broken MII_OUI macro implementation in FreeBSD. > > Because PHY vendors also made the same mistake as FreeBSD this > > hasn't been much problem so far. Would you apply the following > > patch and let me know the output of ukphy(4)? > > Please see following result. > - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - > miibus0: on axe0 > ukphy0: PHY 0 on miibus0 > ukphy0: OUI 0x1e525e, model 0x0014, rev. 9 > ukphy0: 10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, 1000baseSX, 1000baseT, 1000baseT-FDX, auto > ukphy0: IDR1 = 0x7949, IDR2 = 0x7949 Hmm, this also looks like faked one. Probably PHY address was incorrectly chosen. I guess the PHY would be one of Marvell variants. If this is correct guess, I think ax88178_init() should be called prior to any other operations(patch attached). Sam, what's your opinion? -- Regards, Pyun YongHyeon --1LKvkjL3sHcu1TtY Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="axe.patch" --- if_axe.c.orig 2008-06-03 11:09:23.000000000 +0900 +++ if_axe.c 2008-06-03 17:41:16.000000000 +0900 @@ -608,14 +608,14 @@ AXE_SLEEPLOCK(sc); AXE_LOCK(sc); - /* We need the PHYID for the init dance in some cases */ - axe_cmd(sc, AXE_CMD_READ_PHYID, 0, 0, (void *)&sc->axe_phyaddrs); - if (sc->axe_flags & AX178) axe_ax88178_init(sc); else if (sc->axe_flags & AX772) axe_ax88772_init(sc); + /* We need the PHYID for the init dance in some cases */ + axe_cmd(sc, AXE_CMD_READ_PHYID, 0, 0, (void *)&sc->axe_phyaddrs); + /* * Get station address. */ --1LKvkjL3sHcu1TtY--