From owner-svn-ports-head@FreeBSD.ORG Wed Sep 4 12:36:17 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 3CC3C2DB; Wed, 4 Sep 2013 12:36:17 +0000 (UTC) (envelope-from s.montgomerysmith@gmail.com) Received: from mail-ie0-x22d.google.com (mail-ie0-x22d.google.com [IPv6:2607:f8b0:4001:c03::22d]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id D6C8F2F5F; Wed, 4 Sep 2013 12:36:16 +0000 (UTC) Received: by mail-ie0-f173.google.com with SMTP id qa5so349943ieb.32 for ; Wed, 04 Sep 2013 05:36:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=SSBfARSPhGE7WDZ6wWKe2paBGL0GhbQHImRCY/IhUd4=; b=q+ykgNX+pLY2aZeHGz0BLQr7Yhk63tN3WZbPRZvi938HoC7/jSxZ6LDwQAIbhN7QBU XyXRAxQRynBxkKgGj2FrvVwGAAvVUQ+mRXI3h4z29i0razreYpe/Xgrr7J3f0DDlGks3 T6zhbuPuXoK3hLCerFwcl3Ziw2r52bxYoF5HoDrE0CyVgKIQfS9rOvo0mwAnSyrXkE56 lrlO6frATrRPySbgmENokiAf1Bysx2zo1IwPg8xYqfFOJCOEL+vf49rsyTC2ettsBxWU 4TFwV9+6FWx5JueIIrWlG3n5JGanPyFFUfMXkEowHu+CJKv/lpi4lTRo7gGFnQgjYc59 Py9A== X-Received: by 10.43.125.4 with SMTP id gq4mr1607183icc.1.1378298175874; Wed, 04 Sep 2013 05:36:15 -0700 (PDT) Received: from [192.168.0.11] (50-82-246-58.client.mchsi.com. [50.82.246.58]) by mx.google.com with ESMTPSA id i1sm3998942iga.0.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 04 Sep 2013 05:36:15 -0700 (PDT) Sender: Stephen Montgomery-Smith Message-ID: <5227293D.30108@missouri.edu> Date: Wed, 04 Sep 2013 07:36:13 -0500 From: Stephen Montgomery-Smith User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 MIME-Version: 1.0 To: Alexey Dokuchaev Subject: Re: svn commit: r326241 - head/math/octave-forge-odepkg References: <201309040138.r841cHYC074414@svn.freebsd.org> <20130904033030.GC71557@FreeBSD.org> In-Reply-To: <20130904033030.GC71557@FreeBSD.org> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Stephen Montgomery-Smith , ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Sep 2013 12:36:17 -0000 On 09/03/2013 10:30 PM, Alexey Dokuchaev wrote: > On Wed, Sep 04, 2013 at 01:38:17AM +0000, Stephen Montgomery-Smith wrote: >> New Revision: 326241 >> URL: http://svnweb.freebsd.org/changeset/ports/326241 >> >> Log: >> - Set make_jobs_unsafe, otherwise patches can get applied out of order. With this particular port, I am not quite sure exactly what goes wrong. But at some point, it applies a whole bunch of patches within its Makefile. And I was getting "patch already applied" errors. Something was being done out of order - maybe it wasn't specifically the application of the patches. > > Do you see any better solution to this? Maybe force the order somehow? > MAKE_JOBS_UNSAFE should be used as a last resort, when problem cannot be > easily fixed. > > ./danfe (dreaming of 100% jobs-safe ports tree :) I probably could try to find a fix (but I'll have to read up on how gmake performs its -j operations first). However, from a philosophical point of view, if a project external to FreeBSD makes source code that is not safe for the -j option to be used, should FreeBSD ports committers feel that it is our job to correct their source code? I think the answer should be "no," and it seems you disagree. I would like to hear what other people think.