From owner-freebsd-sparc64@FreeBSD.ORG Sun Feb 22 11:25:18 2004 Return-Path: Delivered-To: freebsd-sparc64@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DBCAD16A4CE for ; Sun, 22 Feb 2004 11:25:18 -0800 (PST) Received: from electra.cse.Buffalo.EDU (electra.cse.Buffalo.EDU [128.205.32.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 95B3443D1D for ; Sun, 22 Feb 2004 11:25:18 -0800 (PST) (envelope-from kensmith@cse.Buffalo.EDU) Received: from electra.cse.Buffalo.EDU (kensmith@localhost [127.0.0.1]) i1MJPGTr025556; Sun, 22 Feb 2004 14:25:16 -0500 (EST) Received: (from kensmith@localhost) by electra.cse.Buffalo.EDU (8.12.10/8.12.9/Submit) id i1MJPGYb025555; Sun, 22 Feb 2004 14:25:16 -0500 (EST) Date: Sun, 22 Feb 2004 14:25:16 -0500 From: Ken Smith To: Marcel Moolenaar Message-ID: <20040222192516.GC25047@electra.cse.Buffalo.EDU> References: <20040215060047.GA62840@dhcp01.pn.xcllnt.net> <20040215165913.M30161@grogged.dyndns.org> <20040222191618.GB53610@dhcp01.pn.xcllnt.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040222191618.GB53610@dhcp01.pn.xcllnt.net> User-Agent: Mutt/1.4.1i cc: Garance A Drosihn cc: sparc64@freebsd.org Subject: Re: Problem with DHCLIENT vs 64-bit time_t X-BeenThere: freebsd-sparc64@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting FreeBSD to the Sparc List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Feb 2004 19:25:19 -0000 On Sun, Feb 22, 2004 at 11:16:18AM -0800, Marcel Moolenaar wrote: > On Sun, Feb 22, 2004 at 11:45:52AM +0100, Dag-Erling Sm?rgrav wrote: > > > > Only takes a few minutes of eyeballing to figure out that the problem > > is most likely on line 424 of src/contrib/isc-dhcp/common/parse.c: > > > > convert_num (cfile, (unsigned char *)timep, val, 10, 32); > > > > idiotically, the final argument to convert_num() is supposed to be the > > size in bits of the number to store in the location pointed to by the > > second argument. The simplest fix is to use a temporary int32_t and > > assign it to *timep later, since convert_num() can't deal with 64-bit > > quantities. See attached (untested) patch. > > This code is then obviously also broken on amd64 and ia64 and thus > makes the bug more severe. A work-around seems to be in order until > isc-dhcp gets upgraded. IMO of course, > Since the ISO's done I can try to take care of this if nobody else wants to. Would be nice to have it fixed before I do the next snapshot (right after Garance does the real commit). I'd just be trying to confirm Dag-Erling's patch works and then running it by my mentor... -- Ken Smith - From there to here, from here to | kensmith@cse.buffalo.edu there, funny things are everywhere. | - Theodore Geisel |