From owner-freebsd-bugs  Fri Jun 23 07:38:33 1995
Return-Path: bugs-owner
Received: (from majordom@localhost)
          by freefall.cdrom.com (8.6.10/8.6.6) id HAA08086
          for bugs-outgoing; Fri, 23 Jun 1995 07:38:33 -0700
Received: (from root@localhost)
          by freefall.cdrom.com (8.6.10/8.6.6) id HAA08079
          ; Fri, 23 Jun 1995 07:38:33 -0700
Date: Fri, 23 Jun 1995 07:38:33 -0700
Message-Id: <199506231438.HAA08079@freefall.cdrom.com>
From: Stefan Petri <petri@ibr.cs.tu-bs.de>
Reply-To: Stefan Petri <petri@ibr.cs.tu-bs.de>
To: freebsd-bugs
Subject: i386/548: missing break in isa/if_el.c causes panic in bpf.c + fix
In-Reply-To: Your message of Fri, 9 Jun 1995 17:58:15 +0200
	<199506091558.RAA05474@achill.ibr.cs.tu-bs.de>
Sender: bugs-owner@FreeBSD.org
Precedence: bulk


>Number:         548
>Category:       i386
>Synopsis:       missing break in isa/if_el.c causes panic in bpf.c + fix
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-bugs (FreeBSD bugs mailing list)
>State:          open
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jun 23 07:38:32 1995
>Originator:     Stefan Petri
>Organization:
TU Braunschweig, Inst. f. Betriebssysteme u. Rechnerverbund
>Release:        FreeBSD 2.0-950412-SNAP i386
>Environment:

	FreeBSD 2.0-950412-SNAP, some PC with (dont laugh) 3C501 Ethernet
	card.

>Description:

	The kernel's bpf module panics when turning off promiscous mode
	on a 3C501 ethernet card (interface el0). The reason is a missing
	``break'' statement after the SIOCSIFFLAGS case in the big switch
	in el_ioctl() in i386/isa/if_el.c

>How-To-Repeat:

	> tcpdump -i el0
	tcpdump: listening on el0
	[..packet printout deleted..]
	^C

	panic: bpf: ifpromisc failed
	[..]

>Fix:
	

*** /usr/src/sys/i386/isa/if_el.c-2.0-950412-SNAP	Wed Apr 12 22:47:48 1995
--- if_el.c	Thu Jun  8 19:13:53 1995
***************
*** 768,773 ****
--- 768,774 ----
  		    	    ((ifp->if_flags & IFF_RUNNING) == 0))
  				el_init(ifp->if_unit);
  		}
+ 		break;
  
  	case SIOCSIFMTU:
  


>Audit-Trail:
>Unformatted: