From owner-cvs-all@FreeBSD.ORG  Sat Mar 19 15:15:59 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id BD80116A4CE; Sat, 19 Mar 2005 15:15:59 +0000 (GMT)
Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 5A4A743D1F; Sat, 19 Mar 2005 15:15:59 +0000 (GMT)
	(envelope-from scottl@samsco.org)
Received: from [192.168.254.11] (junior-wifi.samsco.home [192.168.254.11])
	(authenticated bits=0)
	by pooker.samsco.org (8.13.1/8.13.1) with ESMTP id j2JFFK3c044585;
	Sat, 19 Mar 2005 08:15:21 -0700 (MST)
	(envelope-from scottl@samsco.org)
Message-ID: <423C418D.4080104@samsco.org>
Date: Sat, 19 Mar 2005 08:13:17 -0700
From: Scott Long <scottl@samsco.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.5) Gecko/20050218
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Poul-Henning Kamp <phk@phk.freebsd.dk>
References: <23463.1111232399@critter.freebsd.dk>
In-Reply-To: <23463.1111232399@critter.freebsd.dk>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-2.8 required=3.8 tests=ALL_TRUSTED autolearn=failed 
	version=3.0.2
X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on pooker.samsco.org
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: David Xu <davidxu@FreeBSD.org>
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern kern_thread.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 19 Mar 2005 15:15:59 -0000

Poul-Henning Kamp wrote:
> In message <423C0A0F.6090409@freebsd.org>, David Xu writes:
> 
>>Poul-Henning Kamp wrote:
>>
>>
>>>phk         2005-03-19 08:22:13 UTC
>>>
>>> FreeBSD src repository
>>>
>>> Sleeping is not allowed in uma->fini
>>>
>>
>>I have not tested if this change will hurt libpthread performance,
>>but it is obvious that benifit of uma cache will be reduced by
>>this change.
> 
> 
> I am aware of that and I don't like it either.
> 
> The problem is that the uma_mutex is held over the uma->fini() call
> and I'm surprised that we set so tight constraints on these functions
> but I did not manage to corner the UMA crew and talk to them about it
> yesterday evening.
> 
> One obvious solution is to taskq the release of the unit number.
> 

Since unit number release isn't a time-critical operation (right?), it
sounds like a perfect candidate for a taskqueue.

Scott