From owner-freebsd-stable@FreeBSD.ORG  Tue Dec  7 23:06:35 2004
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id DC70216A4CE; Tue,  7 Dec 2004 23:06:35 +0000 (GMT)
Received: from mail.vicor-nb.com (bigwoop.vicor-nb.com [208.206.78.2])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 00D9D43D31; Tue,  7 Dec 2004 23:06:35 +0000 (GMT)
	(envelope-from julian@elischer.org)
Received: from elischer.org (julian.vicor-nb.com [208.206.78.97])
	by mail.vicor-nb.com (Postfix) with ESMTP
	id A7F637A403; Tue,  7 Dec 2004 15:06:34 -0800 (PST)
Message-ID: <41B6377A.2070003@elischer.org>
Date: Tue, 07 Dec 2004 15:06:34 -0800
From: Julian Elischer <julian@elischer.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.3.1) Gecko/20030516
X-Accept-Language: en, hu
MIME-Version: 1.0
To: Gleb Smirnoff <glebius@freebsd.org>
References: <20041202151048.GA33485@cell.sick.ru>
	<20041207124154.GA76825@cell.sick.ru>
In-Reply-To: <20041207124154.GA76825@cell.sick.ru>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
cc: stable@freebsd.org
cc: current@freebsd.org
Subject: Re: [TEST] netgraph callout interface
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Production branch of FreeBSD source code
	<freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Dec 2004 23:06:36 -0000



Gleb Smirnoff wrote:

>  The patch at 
>
>	http://people.freebsd.org/~glebius/totest/netgraph_callout
>
>has been updated. Now it covers the following nodes:
>
>	ng_bridge.c
>	ng_l2tp.c
>	ng_lmi.c
>	ng_pppoe.c
>	ng_pptpgre.c
>
>One more time I ask for testing. The patch can be applied both to HEAD
>and RELENG_5.
>
the bits I am familiar with look reasonable.

>	
>On Thu, Dec 02, 2004 at 06:10:48PM +0300, Gleb Smirnoff wrote:
>T>   Dear collegues,
>T> 
>T>   we are working on making netgraph ISR mpsafe. To do it we need to
>T> fix all (ab)users of bare timeout(9) in src/sys/netgraph. These
>T> timeout calls are running in synch with netgraph now because timeout(9)
>T> is Giant-locked. As soon as we mark ISR mpsafe, they are going to break.
>T> 
>T> This patch semi-mechanically changes all timeout(9) calls to ng_callout(9),
>T> which runs scheduled callouts in netgraph context:
>T> 
>T> 	http://people.freebsd.org/~glebius/totest/netgraph_callout
>T> 
>T> It can be applied to HEAD or RELENG_5 (not 5.3-RELEASE). It patches
>T> the following nodes:
>T> 
>T> 	ng_bridge.c
>T> 	ng_l2tp.c
>T> 	ng_lmi.c
>T> 	ng_ppp.c
>T> 	ng_pppoe.c
>T> 	ng_tty.c
>T> 
>T> If you are using at least one of them, then I'm asking you to test the
>T> patch and respond. Thanks in advance!
>T> 
>T> P.S. Sorry for crossposting. The target users are both RELENG_5 and CURRENT.
>
>  
>