From owner-svn-src-all@FreeBSD.ORG Sat Mar 28 09:13:43 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5873F901; Sat, 28 Mar 2015 09:13:43 +0000 (UTC) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D7610942; Sat, 28 Mar 2015 09:13:42 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.9/8.14.9) with ESMTP id t2S9Dbsg029481 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Sat, 28 Mar 2015 11:13:37 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.9.2 kib.kiev.ua t2S9Dbsg029481 Received: (from kostik@localhost) by tom.home (8.14.9/8.14.9/Submit) id t2S9Dau3029480; Sat, 28 Mar 2015 11:13:37 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 28 Mar 2015 11:13:36 +0200 From: Konstantin Belousov To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r280780 - head/sys/amd64/amd64 Message-ID: <20150328091336.GT2379@kib.kiev.ua> References: <201503280902.t2S92K0p013242@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201503280902.t2S92K0p013242@svn.freebsd.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on tom.home X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Mar 2015 09:13:43 -0000 On Sat, Mar 28, 2015 at 09:02:20AM +0000, Konstantin Belousov wrote: > Author: kib > Date: Sat Mar 28 09:02:19 2015 > New Revision: 280780 > URL: https://svnweb.freebsd.org/changeset/base/280780 > > Log: > The #ss fault handler erronously does not check for the fault > originated from the return to usermode. #ss must be handled same as > #np. Note that this is an omission in r275833. I fixed the wrong gs base for #ss and #np, but failed to note the lack of required check for iretd faulting on the way to usermode for #ss. So this is not a 'security' issue, only the local DoS: kernel excessively panics instead of delivering trap to userspace.