From owner-freebsd-current@FreeBSD.ORG Mon Aug 26 14:01:57 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 6E1CCF48 for ; Mon, 26 Aug 2013 14:01:57 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id D3207264B for ; Mon, 26 Aug 2013 14:01:56 +0000 (UTC) Received: (qmail 6678 invoked from network); 26 Aug 2013 14:44:07 -0000 Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 26 Aug 2013 14:44:07 -0000 Message-ID: <521B5FD0.3020405@freebsd.org> Date: Mon, 26 Aug 2013 16:01:52 +0200 From: Andre Oppermann User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= Subject: Re: [PATCH] xen-netback: fix compile errors introduced by r254804 and r254807 References: <1377514921-2132-1-git-send-email-roger.pau@citrix.com> <521B569C.4080906@freebsd.org> <521B5B8E.6060806@citrix.com> In-Reply-To: <521B5B8E.6060806@citrix.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Cc: freebsd-current@freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Aug 2013 14:01:57 -0000 On 26.08.2013 15:43, Roger Pau Monné wrote: > On 26/08/13 15:22, Andre Oppermann wrote: >> On 26.08.2013 13:02, Roger Pau Monne wrote: >>> r254804 and r254807 changed the types of some of the members of the >>> mbuf struct, and introduced some compile time errors in netback >>> debug messages that prevented compiling a XENHVM kernel. >> >> Thanks, I fixed the printf's with r254910 in a slightly different way just >> before I saw your email. > > Thanks, just saw your fix on the repos. > >> There's a dedicated m_print() function upcoming that can/should replace all >> those hand-grown variants. > > That should be helpful. I was wondering if there's a way to add the > XENHVM kernel configs to the tinderbox tester, so we can at least have a > compile test for XEN PVHVM kernels. It is and that's where I saw it. There's so many kernels to compile these days to get complete code coverage. -- Andre