From owner-freebsd-usb@FreeBSD.ORG Sat Jun 30 12:50:04 2007 Return-Path: X-Original-To: freebsd-usb@hub.freebsd.org Delivered-To: freebsd-usb@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 645A516A41F for ; Sat, 30 Jun 2007 12:50:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id 3C77F13C45E for ; Sat, 30 Jun 2007 12:50:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l5UCo4cH035691 for ; Sat, 30 Jun 2007 12:50:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l5UCo43k035690; Sat, 30 Jun 2007 12:50:04 GMT (envelope-from gnats) Resent-Date: Sat, 30 Jun 2007 12:50:04 GMT Resent-Message-Id: <200706301250.l5UCo43k035690@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-usb@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Ulrich Spoerlein Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4347016A400 for ; Sat, 30 Jun 2007 12:49:11 +0000 (UTC) (envelope-from uspoerlein@gmail.com) Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.170]) by mx1.freebsd.org (Postfix) with ESMTP id C2FD913C458 for ; Sat, 30 Jun 2007 12:49:09 +0000 (UTC) (envelope-from uspoerlein@gmail.com) Received: by ug-out-1314.google.com with SMTP id o4so563836uge for ; Sat, 30 Jun 2007 05:49:09 -0700 (PDT) Received: by 10.67.89.5 with SMTP id r5mr1743341ugl.1183207749130; Sat, 30 Jun 2007 05:49:09 -0700 (PDT) Received: from roadrunner.q.local ( [85.180.181.128]) by mx.google.com with ESMTP id j12sm11082287fkf.2007.06.30.05.49.08 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 30 Jun 2007 05:49:08 -0700 (PDT) Received: from roadrunner.q.local (localhost [127.0.0.1]) by roadrunner.q.local (8.14.1/8.14.1) with ESMTP id l5UClMl7008745; Sat, 30 Jun 2007 14:47:22 +0200 (CEST) (envelope-from q@roadrunner.q.local) Received: (from q@localhost) by roadrunner.q.local (8.14.1/8.14.1/Submit) id l5UClMUY008744; Sat, 30 Jun 2007 14:47:22 +0200 (CEST) (envelope-from q) Message-Id: <200706301247.l5UClMUY008744@roadrunner.q.local> Date: Sat, 30 Jun 2007 14:47:22 +0200 (CEST) From: Ulrich Spoerlein To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Warner Losh Subject: usb/114154: [PATCH] umass quirk: Samsung YP-U2 USB MP3/Ogg Player X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Ulrich Spoerlein List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Jun 2007 12:50:04 -0000 >Number: 114154 >Category: usb >Synopsis: [PATCH] umass quirk: Samsung YP-U2 USB MP3/Ogg Player >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-usb >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sat Jun 30 12:50:03 GMT 2007 >Closed-Date: >Last-Modified: >Originator: Ulrich Spoerlein >Release: FreeBSD 7.0-CURRENT i386 >Organization: >Environment: >Description: Samsung, YP-U2, 1GB MP3/Ogg Vorbis USB stick fails to attach with the old USB stack. It works fine with HPS' USB stack, though. # usbdevs -v Controller /dev/usb3: addr 1: high speed, self powered, config 1, EHCI root hub(0x0000), Intel(0x0000), rev 1.00 port 1 addr 8: high speed, power 500 mA, config 1, product 0x5050(0x5050), vendor 0x04e8(0x04e8), rev 10.01 # camcontrol inquiry da0 pass0: Removable Direct Access SCSI-4 device pass0: Serial Number 4002F9D69D94469B 40.000MB/s transfers # dmesg, no quirk umass0: on uhub3 umass0: SCSI over Bulk-Only; quirks = 0x0000 umass0:1:0:-1: Attached to scbus1 umass0: BBB reset failed, TIMEOUT umass0: BBB bulk-in clear stall failed, TIMEOUT umass0: BBB bulk-out clear stall failed, IOERROR umass0: BBB reset failed, IOERROR umass0: BBB bulk-in clear stall failed, IOERROR umass0: BBB bulk-out clear stall failed, IOERROR umass0: BBB reset failed, IOERROR umass0: BBB bulk-in clear stall failed, IOERROR umass0: BBB bulk-out clear stall failed, IOERROR umass0: BBB reset failed, IOERROR umass0: BBB bulk-in clear stall failed, IOERROR umass0: BBB bulk-out clear stall failed, IOERROR umass0: BBB reset failed, IOERROR umass0: BBB bulk-in clear stall failed, IOERROR umass0: BBB bulk-out clear stall failed, IOERROR # dmesg, quirk umass0: on uhub3 umass0: SCSI over Bulk-Only; quirks = 0x0110 umass0:1:0:-1: Attached to scbus1 da0 at umass-sim0 bus 0 target 0 lun 0 da0: Removable Direct Access SCSI-4 device da0: 40.000MB/s transfers da0: 999MB (511616 2048 byte sectors: 64H 32S/T 249C) GEOM_LABEL: Label for provider da0s1 is msdosfs/USBSTICK. >How-To-Repeat: >Fix: Index: dev/usb/umass.c =================================================================== RCS file: /home/ncvs/src/sys/dev/usb/umass.c,v retrieving revision 1.153 diff -u -p -r1.153 umass.c --- dev/usb/umass.c 21 Jun 2007 20:13:07 -0000 1.153 +++ dev/usb/umass.c 30 Jun 2007 12:40:14 -0000 @@ -452,6 +452,10 @@ static struct umass_devdescr_t umass_dev UMASS_PROTO_SCSI | UMASS_PROTO_BBB, IGNORE_RESIDUE | NO_START_STOP }, + { USB_VENDOR_SAMSUNG, USB_PRODUCT_SAMSUNG_YP_U2, RID_WILDCARD, + UMASS_PROTO_SCSI | UMASS_PROTO_BBB, + SHUTTLE_INIT | NO_GETMAXLUN + }, { USB_VENDOR_SANDISK, USB_PRODUCT_SANDISK_SDDR31, RID_WILDCARD, UMASS_PROTO_SCSI | UMASS_PROTO_BBB, READ_CAPACITY_OFFBY1 Index: dev/usb/usbdevs =================================================================== RCS file: /home/ncvs/src/sys/dev/usb/usbdevs,v retrieving revision 1.311 diff -u -p -r1.311 usbdevs --- dev/usb/usbdevs 26 Jun 2007 05:29:27 -0000 1.311 +++ dev/usb/usbdevs 30 Jun 2007 12:40:14 -0000 @@ -1752,6 +1752,7 @@ product SAGEM USBSERIAL 0x0027 USB-Seri /* Samsung products */ product SAMSUNG ML6060 0x3008 ML-6060 laser printer +product SAMSUNG YP_U2 0x5050 YP-U2 MP3 Player product SAMSUNG I500 0x6601 I500 Palm USB Phone /* SanDisk products */ >Release-Note: >Audit-Trail: >Unformatted: