From owner-freebsd-hackers@FreeBSD.ORG  Fri May  1 11:56:58 2009
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3BECA106564A
	for <freebsd-hackers@FreeBSD.org>; Fri,  1 May 2009 11:56:58 +0000 (UTC)
	(envelope-from sobomax@FreeBSD.org)
Received: from sippysoft.com (gk1.360sip.com [72.236.70.240])
	by mx1.freebsd.org (Postfix) with ESMTP id 027EF8FC08
	for <freebsd-hackers@FreeBSD.org>; Fri,  1 May 2009 11:56:57 +0000 (UTC)
	(envelope-from sobomax@FreeBSD.org)
Received: from [192.168.1.38] (S0106001372fd1e07.vs.shawcable.net
	[70.71.171.106]) (authenticated bits=0)
	by sippysoft.com (8.14.3/8.14.3) with ESMTP id n41Butnh011282
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Fri, 1 May 2009 04:56:56 -0700 (PDT)
	(envelope-from sobomax@FreeBSD.org)
Message-ID: <49FAE36D.9030109@FreeBSD.org>
Date: Fri, 01 May 2009 04:56:29 -0700
From: Maxim Sobolev <sobomax@FreeBSD.org>
Organization: Sippy Software, Inc.
User-Agent: Thunderbird 2.0.0.21 (Windows/20090302)
MIME-Version: 1.0
To: Christoph Mallon <christoph.mallon@gmx.de>
References: <49F4070C.2000108@gmx.de> <20090428121327.GA41168@freebsd.org>
	<49FA8F2D.5090708@gmx.de>
In-Reply-To: <49FA8F2D.5090708@gmx.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Ed Schouten <ed@FreeBSD.org>, FreeBSD Hackers <freebsd-hackers@FreeBSD.org>,
	Roman Divacky <rdivacky@FreeBSD.org>, Warner Losh <imp@FreeBSD.org>
Subject: Re: C99: Suggestions for style(9)
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 01 May 2009 11:56:58 -0000

Christoph Mallon wrote:
> Roman Divacky schrieb:
>> I like the part about using as many variables as possible because
>> of documentation and performance enhancements. I tend to like
>> the other changes as well..
> 
> This is not about using as many variables as possible. The goal is to 
> use as many variables as you have logically distinct entities in the 
> function. I suppose, this is what you mean, but I want to clarify this 
> point.

Why don't just put "logically distinct entities" into separate functions 
on their own? It's a good indicator that the re-factoring is due when 
you reach this point.

-Maxim