From owner-svn-src-all@freebsd.org Fri Apr 22 07:55:02 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F2E05B180D3; Fri, 22 Apr 2016 07:55:02 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x231.google.com (mail-pf0-x231.google.com [IPv6:2607:f8b0:400e:c00::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C0F1016E1; Fri, 22 Apr 2016 07:55:02 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x231.google.com with SMTP id n1so38986404pfn.2; Fri, 22 Apr 2016 00:55:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=PkPZ/mWRZbyv4trXLfnGg6kr4DJmRmiYAE8Z3D889Ew=; b=meLHMwtmKcX1XT4QnLZLGhVqhr3KSIJUT1UGMgSzRjF7VaCN+BjffxJYDtNdFFGj1o XDokrTRL+N1VPsuV3+9DYn1l1GZDJetJGt/i50tfXQHWvMIjuYAV8BFDKKERJQA9S9e6 G+dHFRz5FW/QxxMn5sh2X10/Yul+Ni5zEEI2lk5nekAkcIcyglxE0IEMQaq9aBGAQPks i44qwOddJHd8tGYSWZaS1cb2zxAnfnvCJVKVIIDVgNvblpDZeGhvHEymBRu3tDq2e7jS XgCrq8XLfyiTvIOvPkl/M/5gJh2WK9wmqGw62FfYZHDIcJBnOIWhwliv7B6cK/VMDKZD Y+Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=PkPZ/mWRZbyv4trXLfnGg6kr4DJmRmiYAE8Z3D889Ew=; b=auhvwdD8iJge8zdFOmCZF5nQH8HB2WxrLx2f/mPW2DpGDiGXzQcut8lJZ3XNyDKPnc ZzbUyc3j7UgqSOBrXy4ht3uWls04O6xDy3hftwIR66qjzNYP7HN/9kgIKFdE2vFB7Exw 3tpgo7DlC5GB4xpz1GOoh+IcuC1L0IWQM+nDBPncS9M4ikk/issQaSOU1nzLD4DSiX3f mSCvK3caqWzT01cIfODrfPnuSq01/iv66m8Wfd7qqs08R1npWiwIhI6Ho0Mmk3DGDTjp JrgZSzOrojlP/pNqqbkLmpkqoX2WaCBJ+nIutZIPy9OaBGEcQZXcmQ07uQRcOKWR40GN sZ+g== X-Gm-Message-State: AOPr4FVGZ22RhoTXVMdA27w216Qo8S+cGy+6Pgvk//iR1HBnusEvg7jl+ZWLfOONXyaUBQ== X-Received: by 10.98.100.200 with SMTP id y191mr26654911pfb.84.1461311702483; Fri, 22 Apr 2016 00:55:02 -0700 (PDT) Received: from [192.168.20.7] (c-73-97-222-46.hsd1.wa.comcast.net. [73.97.222.46]) by smtp.gmail.com with ESMTPSA id 187sm6115064pff.66.2016.04.22.00.55.01 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 22 Apr 2016 00:55:01 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Subject: Re: svn commit: r298462 - head/contrib/bsnmp/snmp_mibII From: "Ngie Cooper (yaneurabeya)" In-Reply-To: <201604220751.u3M7pcUO033612@repo.freebsd.org> Date: Fri, 22 Apr 2016 00:55:00 -0700 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <3CEC0CBF-09FC-430E-B92F-E554CE66648B@gmail.com> References: <201604220751.u3M7pcUO033612@repo.freebsd.org> To: Garrett Cooper X-Mailer: Apple Mail (2.2104) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Apr 2016 07:55:03 -0000 > On Apr 22, 2016, at 00:51, Garrett Cooper wrote: >=20 > Author: ngie > Date: Fri Apr 22 07:51:38 2016 > New Revision: 298462 > URL: https://svnweb.freebsd.org/changeset/base/298462 >=20 > Log: > Return `ret` in op_ifentry(..) to mute a -Wunused-but-set-variable = warning >=20 > This will also now detect error conditions with > value->var.subs[sub - 1] =3D=3D LEAF_ifPhysAddress where = `string_get(..)` > could fail if iifp->physaddr and/or iifp->physaddrlen were deemed > invalid. >=20 > MFC after: 2 weeks > CID: 1006551 > Reported by: Coverity, gcc > Sponsored by: EMC / Isilon Storage Division I pulled up the wrong CID. Coverity didn=E2=80=99t actually complain = about this =E2=80=94 just gcc. Thanks, -Ngie=