From owner-freebsd-hardware Sun Aug 8 19: 4:47 1999 Delivered-To: freebsd-hardware@freebsd.org Received: from sasami.jurai.net (sasami.jurai.net [63.67.141.99]) by hub.freebsd.org (Postfix) with ESMTP id 9E4DE14E5A for ; Sun, 8 Aug 1999 19:04:43 -0700 (PDT) (envelope-from winter@jurai.net) Received: from localhost (winter@localhost) by sasami.jurai.net (8.8.8/8.8.7) with ESMTP id WAA15262; Sun, 8 Aug 1999 22:01:35 -0400 (EDT) Date: Sun, 8 Aug 1999 22:01:34 -0400 (EDT) From: "Matthew N. Dodd" To: Robert Watson Cc: freebsd-hardware@FreeBSD.ORG Subject: Re: kern/12275: Patches to add support for new chipset (fwd) In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-hardware@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org I may be missing something but this patch contains read_mii() and write_mii() but never does anything with them. I'm going to go out on a limb and make a guess that you really mean: + media = read_mii(sc, BCR49); ... + write_mii(sc, BCR49, media); Any chance that we can identify the PHY used by these cards and make sure we're dealing with one of them before we go reading and writing to one blindly? What if Diamond changes PHYs? Anyhow, I don't see these design issues getting in the way of adding functionality. Regenerate your patch and I'll commit it. (unless someone else wants to.) On Sun, 8 Aug 1999, Robert Watson wrote: > Updated patches to use the Diamond HomeFree home phoneline based network > card (AMD Am79C978) are now available from > > http://www.watson.org/freebsd/hardware/amd_pcnet_home_patch.txt > > The updated version doesn't interfere with the probing of other > lnc-supported ethernet devices, unlike the previous patches. They are > also a little cleaner. > > I've had a number of reports that these cards+patches work for other > people than me, and emails interested in having them comitted. I was > wondering what the procedure for doing this would be? > > Robert N M Watson > > robert@fledge.watson.org http://www.watson.org/~robert/ > PGP key fingerprint: AF B5 5F FF A6 4A 79 37 ED 5F 55 E9 58 04 6A B1 > TIS Labs at Network Associates, Computing Laboratory at Cambridge University > Safeport Network Services > > ---------- Forwarded message ---------- > Date: Sun, 8 Aug 1999 14:36:03 -0400 (EDT) > From: Robert Watson > Reply-To: Robert Watson > To: freebsd-gnats-submit@freebsd.org > Subject: Re: kern/12275: Patches to add support for new chipset > > > Attached are cleaned up patches against -current from Aug 7, and that > don't interfere with the existing lnc supported cards, unlike the previous > patches. I've received a number of emails asking about having this added > to -stable and -current, and reporting success in using the driver. > > Thanks, > > Robert N M Watson > > robert@fledge.watson.org http://www.watson.org/~robert/ > PGP key fingerprint: AF B5 5F FF A6 4A 79 37 ED 5F 55 E9 58 04 6A B1 > TIS Labs at Network Associates, Computing Laboratory at Cambridge University > Safeport Network Services > > -- | Matthew N. Dodd | '78 Datsun 280Z | '75 Volvo 164E | FreeBSD/NetBSD | | winter@jurai.net | 2 x '84 Volvo 245DL | ix86,sparc,pmax | | http://www.jurai.net/~winter | This Space For Rent | ISO8802.5 4ever | To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hardware" in the body of the message