From owner-svn-src-all@FreeBSD.ORG Fri Feb 10 20:09:08 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 52A8C1065672; Fri, 10 Feb 2012 20:09:08 +0000 (UTC) (envelope-from rmh.aybabtu@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id DF7848FC0C; Fri, 10 Feb 2012 20:09:07 +0000 (UTC) Received: by iaeo4 with SMTP id o4so971625iae.13 for ; Fri, 10 Feb 2012 12:09:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=WPcdAhb4/M4TTi/bw9aIaPXrzYtoL2JGn4k66D85sig=; b=w+dQkPE6LvUFX76d4fU0HMg1YGE3CLg8i7fiAojHYx8DqU57yt6LV9XagYJlPhFYqi WOQCsOkGFyQVN7cP0LBLdQ3Gmwre88cdTboZpMWDUG0vef0eu/SiJW5sc5Ca8TFHKhhj Vx5a08suJSWKwNxf1EJAceD38Jdo9WHjKauRk= MIME-Version: 1.0 Received: by 10.42.131.136 with SMTP id z8mr11564397ics.5.1328902958026; Fri, 10 Feb 2012 11:42:38 -0800 (PST) Sender: rmh.aybabtu@gmail.com Received: by 10.43.130.201 with HTTP; Fri, 10 Feb 2012 11:42:37 -0800 (PST) In-Reply-To: References: <201202040054.q140siBP012241@svn.freebsd.org> <4F2CFEE3.6070306@daemonic.se> Date: Fri, 10 Feb 2012 20:42:37 +0100 X-Google-Sender-Auth: UU-i77hd5ttlewZrBuImpQbAXH8 Message-ID: From: Robert Millan To: "Bjoern A. Zeeb" Content-Type: multipart/mixed; boundary=90e6ba6e81ccc1113d04b8a15409 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Konstantin Belousov , Adrian Chadd Subject: Re: svn commit: r230972 - in head: share/mk sys/amd64/conf sys/i386/conf sys/modules sys/modules/drm sys/modules/sound/driver sys/modules/usb tools/build/options X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Feb 2012 20:09:08 -0000 --90e6ba6e81ccc1113d04b8a15409 Content-Type: text/plain; charset=UTF-8 Hi all, Sorry for the late reply. I can't keep up with mail during the week. 2012/2/4, Bjoern A. Zeeb : > And can you please include GENERIC at least in these kernel configs? They > are not building and this breaks a make universe and I guess eventually the > tinderbox as well... Including GENERIC sounds problematic because if both WITHOUT_* files are included, then GENERIC is included twice! As discussed on -arch, the idea was that users would never build WITHOUT_* directly, but rather include them in their custom kernel config. These files weren't intended to be picked up by "make universe" either [1]. It just didn't occur to me that the universe target would pick them up. Here's a possible solution to this patch (untested). In case it looks fine to everyone (and my mentors approve it), I'll definitely test with "make universe" before commit. [1] shame on me for not testing lasest version of my patch with "make universe" -- I only tested the first one which didn't add WITHOUT_* files. -- Robert Millan --90e6ba6e81ccc1113d04b8a15409 Content-Type: text/plain; charset=US-ASCII; name="exclude_without_files.diff" Content-Disposition: attachment; filename="exclude_without_files.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: file0 SW5kZXg6IE1ha2VmaWxlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIE1ha2VmaWxlCShyZXZpc2lvbiAyMzA5NzEp CisrKyBNYWtlZmlsZQkod29ya2luZyBjb3B5KQpAQCAtNDA0LDcgKzQwNCw3IEBACiAuZW5kaWYK IEtFUk5DT05GUyE9CWNkICR7S0VSTlNSQ0RJUn0vJHtUQVJHRVR9L2NvbmYgJiYgXAogCQlmaW5k IFtBLVowLTldKltBLVowLTldIC10eXBlIGYgLW1heGRlcHRoIDAgXAotCQkhIC1uYW1lIERFRkFV TFRTICEgLW5hbWUgTk9URVMKKwkJISAtbmFtZSBERUZBVUxUUyAhIC1uYW1lIE5PVEVTICEgLW5h bWUgV0lUSE9VVF9cKgogdW5pdmVyc2Vfa2VybmNvbmZzOgogLmZvciBrZXJuZWwgaW4gJHtLRVJO Q09ORlN9CiBUQVJHRVRfQVJDSF8ke2tlcm5lbH0hPQljZCAke0tFUk5TUkNESVJ9LyR7VEFSR0VU fS9jb25mICYmIFwK --90e6ba6e81ccc1113d04b8a15409--