From owner-freebsd-fs@FreeBSD.ORG  Mon Sep 27 14:24:49 2010
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id F18F6106564A
	for <freebsd-fs@freebsd.org>; Mon, 27 Sep 2010 14:24:49 +0000 (UTC)
	(envelope-from cal@linu.gs)
Received: from mail.adm.hostpoint.ch (mail.adm.hostpoint.ch [217.26.48.124])
	by mx1.freebsd.org (Postfix) with ESMTP id B2CF28FC14
	for <freebsd-fs@freebsd.org>; Mon, 27 Sep 2010 14:24:49 +0000 (UTC)
Received: from [77.109.131.203] (port=39421 helo=aare.localnet)
	by mail.adm.hostpoint.ch with esmtpsa (TLSv1:AES256-SHA:256)
	(Exim 4.69 (FreeBSD)) (envelope-from <cal@linu.gs>)
	id 1P0EdL-0006oU-3B
	for freebsd-fs@freebsd.org; Mon, 27 Sep 2010 16:24:48 +0200
From: Michael Naef <cal@linu.gs>
To: "freebsd-fs" <freebsd-fs@freebsd.org>
Date: Mon, 27 Sep 2010 16:24:42 +0200
User-Agent: KMail/1.13.5 (Linux/2.6.34-gentoo-r1; KDE/4.4.5; i686; ; )
References: <201009231938.09548.cal@linu.gs>
	<66757A1E-E445-4AAD-8F57-382D85BFD579@hostpoint.ch>
In-Reply-To: <66757A1E-E445-4AAD-8F57-382D85BFD579@hostpoint.ch>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201009271624.46655.cal@linu.gs>
Subject: Re: Strange behaviour with sappend flag set on ZFS
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Sep 2010 14:24:50 -0000

Hi all

On Friday 24 September 2010 01:15:55 Markus Gebert wrote:

> CURRENT and STABLE-8 seem to be affected to. The following patch
> seems to fix it (at least Michi's test case works fine with
> it):
> 
> ----
> diff -ru
> ../src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops
> .c ./sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c
> ---
> ../src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops
> .c   2010-05-19 08:49:52.000000000 +0200 +++
> ./sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c   
>     2010-09-23 23:24:43.549846948 +0200 @@ -709,7 +709,7 @@
>          */
>         pflags = zp->z_phys->zp_flags;
>         if ((pflags & (ZFS_IMMUTABLE | ZFS_READONLY)) ||
> -           ((pflags & ZFS_APPENDONLY) && !(ioflag & FAPPEND) &&
> +           ((pflags & ZFS_APPENDONLY) && !(ioflag & IO_APPEND)
> && (uio->uio_loffset < zp->z_phys->zp_size))) {
> ZFS_EXIT(zfsvfs);
>                 return (EPERM);
> ----
> 
> Can someone commit this if the patch is ok? Or should I (or
> Michi) open a PR?

Whats the next step? Is anyboby willing and able to commit the 
patch or should/must I open a PR? (Having a patch for bash which 
solves the most urgent problem, though - but I need a decision.)

cheers and thanks, Michi