From owner-svn-ports-head@FreeBSD.ORG  Fri Apr 11 15:15:22 2014
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id E1BEF2D6;
 Fri, 11 Apr 2014 15:15:22 +0000 (UTC)
Received: from mail-qc0-x232.google.com (mail-qc0-x232.google.com
 [IPv6:2607:f8b0:400d:c01::232])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 7153E1690;
 Fri, 11 Apr 2014 15:15:22 +0000 (UTC)
Received: by mail-qc0-f178.google.com with SMTP id i8so5969192qcq.23
 for <multiple recipients>; Fri, 11 Apr 2014 08:15:21 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date:message-id:subject
 :from:to:cc:content-type;
 bh=0LFdAaosDOIgB0ZmojPEB6xKlUy7wwDTgEM4vhdha7A=;
 b=dQo3TaBUI5+3HO0T/3XsJMAexTIB2byZCSYIzfJBj/cfN9PyoWjFnx6JzNA2uKuhRN
 cAefODrWFyStCCy6SqTcK/XjRKckX71GrpB7vBa0084gCtXbLtIfkNnBDDnyemMXxvOv
 opcRWanyNSuODRVdOrKOpTQykZX0uQu4fg3za+5QhOTyI5M2MW0ls3BKSpz+d5psjlwD
 tCDBT6WKYV07N96usT2Lp79Dx38sUumOOqxQOJZKQzg1bFM7Obl+FUPiyylT/iupmhwh
 /rpIM9ugKP1hlkAs6awZVK6nGWMiGnkEaGAhW+02Zcu6eg4lRAyVI7hpmVwOq9XFcaW5
 QY8A==
MIME-Version: 1.0
X-Received: by 10.140.104.202 with SMTP id a68mr3037220qgf.113.1397229314575; 
 Fri, 11 Apr 2014 08:15:14 -0700 (PDT)
Sender: sjk4015@gmail.com
Received: by 10.140.101.172 with HTTP; Fri, 11 Apr 2014 08:15:14 -0700 (PDT)
In-Reply-To: <20140404151938.GA74064@FreeBSD.org>
References: <201404041511.s34FBhLp047570@svn.freebsd.org>
 <20140404151938.GA74064@FreeBSD.org>
Date: Fri, 11 Apr 2014 11:15:14 -0400
X-Google-Sender-Auth: 0MynVzabtnJ-m4doriKor8KyaF4
Message-ID: <CAFFB+pTBy2Gztk11QL3DT+sYnafU1hNtn6CnQXyWdzjDjo_t_w@mail.gmail.com>
Subject: Re: svn commit: r350132 - in head/security/p5-Crypt-Rabbit: . files
From: Steven Kreuzer <skreuzer@freebsd.org>
To: Alexey Dokuchaev <danfe@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Apr 2014 15:15:23 -0000

On Fri, Apr 4, 2014 at 11:19 AM, Alexey Dokuchaev <danfe@freebsd.org> wrote:
> On Fri, Apr 04, 2014 at 03:11:43PM +0000, Steven Kreuzer wrote:
>> New Revision: 350132
>> URL: http://svnweb.freebsd.org/changeset/ports/350132
>> QAT: https://qat.redports.org/buildarchive/r350132/
>>
>> Log:
>>   Fix build on versions of FreeBSD that don't have gcc as the default
>>   compiler, remove the flag schedule-insns2 passed to cc
>>
>> +@@ -1,6 +1,6 @@
>> + use ExtUtils::MakeMaker;
>> +
>> +-my $opt = '-O3 -funroll-loops -fomit-frame-pointer -fschedule-insns2 -Os -fno-strength-reduce -Wall -pipe';
>> ++my $opt = '-O3 -funroll-loops -fomit-frame-pointer -Os -fno-strength-reduce -Wall -pipe';
>
> Does it make sense to have both -O3 and -Os?  Wouldn't it be better if it
> simply uphold our standard $CFLAGS?

Yeah, very good point. this has been fixed in revision 350979. Thanks