From owner-freebsd-geom@FreeBSD.ORG  Sun Mar 15 10:24:11 2015
Return-Path: <owner-freebsd-geom@FreeBSD.ORG>
Delivered-To: freebsd-geom@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id D6F81D9B
 for <freebsd-geom@freebsd.org>; Sun, 15 Mar 2015 10:24:11 +0000 (UTC)
Received: from smtprelay06.ispgateway.de (smtprelay06.ispgateway.de
 [80.67.31.103])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 93146CBF
 for <freebsd-geom@freebsd.org>; Sun, 15 Mar 2015 10:24:11 +0000 (UTC)
Received: from [87.79.196.203] (helo=fabiankeil.de)
 by smtprelay06.ispgateway.de with esmtpsa (TLSv1.2:AES128-GCM-SHA256:128)
 (Exim 4.84) (envelope-from <freebsd-listen@fabiankeil.de>)
 id 1YX5iE-0006Ut-TQ
 for freebsd-geom@freebsd.org; Sun, 15 Mar 2015 11:24:02 +0100
Date: Sun, 15 Mar 2015 11:24:03 +0100
From: Fabian Keil <freebsd-listen@fabiankeil.de>
To: freebsd-geom@freebsd.org
Subject: Re: RFC: Pass TRIM through GELI
Message-ID: <501bca86.508d8e26@fabiankeil.de>
In-Reply-To: <20150314151453.GJ24274@over-yonder.net>
References: <20150308000131.GP1742@over-yonder.net>
 <20150314151453.GJ24274@over-yonder.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 boundary="Sig_/nNyi7q91bdbUcrQB5QG7+Ze"; protocol="application/pgp-signature"
X-Df-Sender: Nzc1MDY3
X-BeenThere: freebsd-geom@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: GEOM-specific discussions and implementations
 <freebsd-geom.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-geom>,
 <mailto:freebsd-geom-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-geom/>
List-Post: <mailto:freebsd-geom@freebsd.org>
List-Help: <mailto:freebsd-geom-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
 <mailto:freebsd-geom-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 15 Mar 2015 10:24:11 -0000

--Sig_/nNyi7q91bdbUcrQB5QG7+Ze
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

"Matthew D. Fuller" <fullermd@over-yonder.net> wrote:

> > I've done a quick implementation of TRIM passthru support for GELI.
>=20
> Here's a slightly updated version.  Some adjustments to the manpage
> suggested by jmg@, and I've stripped out the new version and checks
> for it.
>=20
> <http://www.over-yonder.net/~fullermd/dl/geli-delete.2.patch>

Awesome. With a kernel based on r279996 the deletes make it to
the zvol and zfs list confirms that the space is marked as free.
ZFS on GELI on zvol works as expected as well.

Additional testing revealed a NULL pointer dereference:
http://www.fabiankeil.de/sourcecode/electrobsd/g_eli_ctl_onetime-Fix-NULL-p=
ointer-dereference.diff

Fabian

--Sig_/nNyi7q91bdbUcrQB5QG7+Ze
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEARECAAYFAlUFXb8ACgkQBYqIVf93VJ33tQCfZUIG+UNrwU3JHbOYEGNQBBW3
abkAnRY022PioZ6KzlIUc3EnWSYf/88p
=I5Tk
-----END PGP SIGNATURE-----

--Sig_/nNyi7q91bdbUcrQB5QG7+Ze--