From owner-svn-src-all@FreeBSD.ORG Thu May 15 13:45:26 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0AB965C5; Thu, 15 May 2014 13:45:26 +0000 (UTC) Received: from i3mail.icecube.wisc.edu (i3mail.icecube.wisc.edu [128.104.255.23]) by mx1.freebsd.org (Postfix) with ESMTP id D2B4F29BF; Thu, 15 May 2014 13:45:25 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by i3mail.icecube.wisc.edu (Postfix) with ESMTP id A0C6D3805A; Thu, 15 May 2014 08:45:19 -0500 (CDT) X-Virus-Scanned: amavisd-new at icecube.wisc.edu Received: from i3mail.icecube.wisc.edu ([127.0.0.1]) by localhost (i3mail.icecube.wisc.edu [127.0.0.1]) (amavisd-new, port 10030) with ESMTP id K1xK6xvLCNDh; Thu, 15 May 2014 08:45:19 -0500 (CDT) Received: from comporellon.tachypleus.net (polaris.tachypleus.net [75.101.50.44]) by i3mail.icecube.wisc.edu (Postfix) with ESMTPSA id 11BDB38056; Thu, 15 May 2014 08:45:18 -0500 (CDT) Message-ID: <5374C4EE.9040201@freebsd.org> Date: Thu, 15 May 2014 06:45:18 -0700 From: Nathan Whitehorn User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Justin Hibbits , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r266116 - head/sys/powerpc/aim References: <201405150418.s4F4I7q4048799@svn.freebsd.org> In-Reply-To: <201405150418.s4F4I7q4048799@svn.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 May 2014 13:45:26 -0000 On 05/14/14 21:18, Justin Hibbits wrote: > Author: jhibbits > Date: Thu May 15 04:18:06 2014 > New Revision: 266116 > URL: http://svnweb.freebsd.org/changeset/base/266116 > > Log: > A page mask size is 12-bits, not 11. > > MFC after: 1 week > > Modified: > head/sys/powerpc/aim/trap_subr32.S > > Modified: head/sys/powerpc/aim/trap_subr32.S > ============================================================================== > --- head/sys/powerpc/aim/trap_subr32.S Thu May 15 03:47:52 2014 (r266115) > +++ head/sys/powerpc/aim/trap_subr32.S Thu May 15 04:18:06 2014 (r266116) > @@ -677,7 +677,7 @@ disitrap: > mtcr %r31 > bt 17,realtrap /* branch is user mode */ > mfsprg1 %r31 /* get old SP */ > - clrrwi %r31,%r31,11 /* Round SP down to nearest page */ > + clrrwi %r31,%r31,12 /* Round SP down to nearest page */ > sub. %r30,%r31,%r30 /* SP - DAR */ > bge 1f > neg %r30,%r30 /* modulo value */ > Is it? 4096 bytes is 2^12. The mask is 4096-1, which is 11 bits all 1. -Nathan